-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratelimit based on JWT claim #7175
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7175 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 89 89
Lines 20843 20843
=======================================
Hits 10992 10992
Misses 9394 9394
Partials 457 457 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I wonder if the example could be made a live documentation page instead of a repo example (I know it's relatively small).
At the least, creating a link to it somewhere from documentation makes it more discoverable.
Bumps the actions group with 2 updates: [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) and [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action). Updates `reviewdog/action-actionlint` from 1.63.0 to 1.64.1 - [Release notes](https://github.com/reviewdog/action-actionlint/releases) - [Commits](reviewdog/action-actionlint@f3dcc52...abd5374) Updates `DavidAnson/markdownlint-cli2-action` from 19.0.0 to 19.1.0 - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@a23dae2...05f3221) --- updated-dependencies: - dependency-name: reviewdog/action-actionlint dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Venktesh Shivam Patel <[email protected]>
fecfc73
to
81dea70
Compare
Proposed changes
Allow the rate-limiting policy to use a
$jwt_claim_
variable to be used as the key in the rate limit zoneChecklist
Before creating a PR, run through this checklist and mark each as complete.