Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update master/minion allowed ingress annotations #7151

Merged
merged 2 commits into from
Jan 17, 2025
Merged

update master/minion allowed ingress annotations #7151

merged 2 commits into from
Jan 17, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 17, 2025

Proposed changes

Update example master/minion allowed ingress annotation list. List driven by masterDenylist, minionDenylist & minionInheritanceList in internal/configs/annotations.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 17, 2025 09:37
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 17, 2025
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Jan 17, 2025
@pdabelf5 pdabelf5 merged commit 4e09c39 into main Jan 17, 2025
28 checks passed
@pdabelf5 pdabelf5 deleted the minion-docs branch January 17, 2025 09:50
@pdabelf5 pdabelf5 self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants