-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor App Protect DoS controller (#6212)
move App Protect DOS controller code to it's own file
- Loading branch information
Showing
3 changed files
with
297 additions
and
280 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,297 @@ | ||
/** | ||
* Copyright (c) F5, Inc. | ||
* | ||
* This source code is licensed under the Apache License, Version 2.0 license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
package k8s | ||
|
||
import ( | ||
"fmt" | ||
"reflect" | ||
|
||
"github.com/golang/glog" | ||
"github.com/nginxinc/kubernetes-ingress/internal/k8s/appprotectdos" | ||
"github.com/nginxinc/kubernetes-ingress/pkg/apis/dos/v1beta1" | ||
api_v1 "k8s.io/api/core/v1" | ||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
"k8s.io/client-go/tools/cache" | ||
) | ||
|
||
func createAppProtectDosPolicyHandlers(lbc *LoadBalancerController) cache.ResourceEventHandlerFuncs { | ||
handlers := cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { | ||
pol := obj.(*unstructured.Unstructured) | ||
glog.V(3).Infof("Adding AppProtectDosPolicy: %v", pol.GetName()) | ||
lbc.AddSyncQueue(pol) | ||
}, | ||
UpdateFunc: func(oldObj, obj interface{}) { | ||
oldPol := oldObj.(*unstructured.Unstructured) | ||
newPol := obj.(*unstructured.Unstructured) | ||
different, err := areResourcesDifferent(oldPol, newPol) | ||
if err != nil { | ||
glog.V(3).Infof("Error when comparing policy %v", err) | ||
lbc.AddSyncQueue(newPol) | ||
} | ||
if different { | ||
glog.V(3).Infof("ApDosPolicy %v changed, syncing", oldPol.GetName()) | ||
lbc.AddSyncQueue(newPol) | ||
} | ||
}, | ||
DeleteFunc: func(obj interface{}) { | ||
lbc.AddSyncQueue(obj) | ||
}, | ||
} | ||
return handlers | ||
} | ||
|
||
func createAppProtectDosLogConfHandlers(lbc *LoadBalancerController) cache.ResourceEventHandlerFuncs { | ||
handlers := cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { | ||
conf := obj.(*unstructured.Unstructured) | ||
glog.V(3).Infof("Adding AppProtectDosLogConf: %v", conf.GetName()) | ||
lbc.AddSyncQueue(conf) | ||
}, | ||
UpdateFunc: func(oldObj, obj interface{}) { | ||
oldConf := oldObj.(*unstructured.Unstructured) | ||
newConf := obj.(*unstructured.Unstructured) | ||
different, err := areResourcesDifferent(oldConf, newConf) | ||
if err != nil { | ||
glog.V(3).Infof("Error when comparing DosLogConfs %v", err) | ||
lbc.AddSyncQueue(newConf) | ||
} | ||
if different { | ||
glog.V(3).Infof("ApDosLogConf %v changed, syncing", oldConf.GetName()) | ||
lbc.AddSyncQueue(newConf) | ||
} | ||
}, | ||
DeleteFunc: func(obj interface{}) { | ||
lbc.AddSyncQueue(obj) | ||
}, | ||
} | ||
return handlers | ||
} | ||
|
||
func createAppProtectDosProtectedResourceHandlers(lbc *LoadBalancerController) cache.ResourceEventHandlerFuncs { | ||
handlers := cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { | ||
conf := obj.(*v1beta1.DosProtectedResource) | ||
glog.V(3).Infof("Adding DosProtectedResource: %v", conf.GetName()) | ||
lbc.AddSyncQueue(conf) | ||
}, | ||
UpdateFunc: func(oldObj, obj interface{}) { | ||
oldConf := oldObj.(*v1beta1.DosProtectedResource) | ||
newConf := obj.(*v1beta1.DosProtectedResource) | ||
|
||
if !reflect.DeepEqual(oldConf.Spec, newConf.Spec) { | ||
glog.V(3).Infof("DosProtectedResource %v changed, syncing", oldConf.GetName()) | ||
lbc.AddSyncQueue(newConf) | ||
} | ||
}, | ||
DeleteFunc: func(obj interface{}) { | ||
lbc.AddSyncQueue(obj) | ||
}, | ||
} | ||
return handlers | ||
} | ||
|
||
// addAppProtectDosPolicyHandler creates dynamic informers for custom appprotectdos policy resource | ||
func (nsi *namespacedInformer) addAppProtectDosPolicyHandler(handlers cache.ResourceEventHandlerFuncs) { | ||
informer := nsi.dynInformerFactory.ForResource(appprotectdos.DosPolicyGVR).Informer() | ||
informer.AddEventHandler(handlers) //nolint:errcheck,gosec | ||
nsi.appProtectDosPolicyLister = informer.GetStore() | ||
|
||
nsi.cacheSyncs = append(nsi.cacheSyncs, informer.HasSynced) | ||
} | ||
|
||
// addAppProtectDosLogConfHandler creates dynamic informer for custom appprotectdos logging config resource | ||
func (nsi *namespacedInformer) addAppProtectDosLogConfHandler(handlers cache.ResourceEventHandlerFuncs) { | ||
informer := nsi.dynInformerFactory.ForResource(appprotectdos.DosLogConfGVR).Informer() | ||
informer.AddEventHandler(handlers) //nolint:errcheck,gosec | ||
nsi.appProtectDosLogConfLister = informer.GetStore() | ||
|
||
nsi.cacheSyncs = append(nsi.cacheSyncs, informer.HasSynced) | ||
} | ||
|
||
// addAppProtectDosLogConfHandler creates dynamic informers for custom appprotectdos logging config resource | ||
func (nsi *namespacedInformer) addAppProtectDosProtectedResourceHandler(handlers cache.ResourceEventHandlerFuncs) { | ||
informer := nsi.confSharedInformerFactory.Appprotectdos().V1beta1().DosProtectedResources().Informer() | ||
informer.AddEventHandler(handlers) //nolint:errcheck,gosec | ||
nsi.appProtectDosProtectedLister = informer.GetStore() | ||
|
||
nsi.cacheSyncs = append(nsi.cacheSyncs, informer.HasSynced) | ||
} | ||
|
||
func (lbc *LoadBalancerController) syncAppProtectDosPolicy(task task) { | ||
key := task.Key | ||
glog.V(3).Infof("Syncing AppProtectDosPolicy %v", key) | ||
var obj interface{} | ||
var polExists bool | ||
var err error | ||
|
||
ns, _, _ := cache.SplitMetaNamespaceKey(key) | ||
obj, polExists, err = lbc.getNamespacedInformer(ns).appProtectDosPolicyLister.GetByKey(key) | ||
if err != nil { | ||
lbc.syncQueue.Requeue(task, err) | ||
return | ||
} | ||
|
||
var changes []appprotectdos.Change | ||
var problems []appprotectdos.Problem | ||
|
||
if !polExists { | ||
glog.V(2).Infof("Deleting APDosPolicy: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.DeletePolicy(key) | ||
} else { | ||
glog.V(2).Infof("Adding or Updating APDosPolicy: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.AddOrUpdatePolicy(obj.(*unstructured.Unstructured)) | ||
} | ||
|
||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
|
||
func (lbc *LoadBalancerController) syncAppProtectDosLogConf(task task) { | ||
key := task.Key | ||
glog.V(3).Infof("Syncing APDosLogConf %v", key) | ||
var obj interface{} | ||
var confExists bool | ||
var err error | ||
|
||
ns, _, _ := cache.SplitMetaNamespaceKey(key) | ||
obj, confExists, err = lbc.getNamespacedInformer(ns).appProtectDosLogConfLister.GetByKey(key) | ||
if err != nil { | ||
lbc.syncQueue.Requeue(task, err) | ||
return | ||
} | ||
|
||
var changes []appprotectdos.Change | ||
var problems []appprotectdos.Problem | ||
|
||
if !confExists { | ||
glog.V(2).Infof("Deleting APDosLogConf: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.DeleteLogConf(key) | ||
} else { | ||
glog.V(2).Infof("Adding or Updating APDosLogConf: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.AddOrUpdateLogConf(obj.(*unstructured.Unstructured)) | ||
} | ||
|
||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
|
||
func (lbc *LoadBalancerController) syncDosProtectedResource(task task) { | ||
key := task.Key | ||
glog.V(3).Infof("Syncing DosProtectedResource %v", key) | ||
var obj interface{} | ||
var confExists bool | ||
var err error | ||
|
||
ns, _, _ := cache.SplitMetaNamespaceKey(key) | ||
obj, confExists, err = lbc.getNamespacedInformer(ns).appProtectDosProtectedLister.GetByKey(key) | ||
if err != nil { | ||
lbc.syncQueue.Requeue(task, err) | ||
return | ||
} | ||
|
||
var changes []appprotectdos.Change | ||
var problems []appprotectdos.Problem | ||
|
||
if confExists { | ||
glog.V(2).Infof("Adding or Updating DosProtectedResource: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.AddOrUpdateDosProtectedResource(obj.(*v1beta1.DosProtectedResource)) | ||
} else { | ||
glog.V(2).Infof("Deleting DosProtectedResource: %v\n", key) | ||
changes, problems = lbc.dosConfiguration.DeleteProtectedResource(key) | ||
} | ||
|
||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
|
||
func (lbc *LoadBalancerController) processAppProtectDosChanges(changes []appprotectdos.Change) { | ||
glog.V(3).Infof("Processing %v App Protect Dos changes", len(changes)) | ||
|
||
for _, c := range changes { | ||
if c.Op == appprotectdos.AddOrUpdate { | ||
switch impl := c.Resource.(type) { | ||
case *appprotectdos.DosProtectedResourceEx: | ||
glog.V(3).Infof("handling change UPDATE OR ADD for DOS protected %s/%s", impl.Obj.Namespace, impl.Obj.Name) | ||
resources := lbc.configuration.FindResourcesForAppProtectDosProtected(impl.Obj.Namespace, impl.Obj.Name) | ||
resourceExes := lbc.createExtendedResources(resources) | ||
warnings, err := lbc.configurator.AddOrUpdateResourcesThatUseDosProtected(resourceExes.IngressExes, resourceExes.MergeableIngresses, resourceExes.VirtualServerExes) | ||
lbc.updateResourcesStatusAndEvents(resources, warnings, err) | ||
msg := fmt.Sprintf("Configuration for %s/%s was added or updated", impl.Obj.Namespace, impl.Obj.Name) | ||
lbc.recorder.Event(impl.Obj, api_v1.EventTypeNormal, "AddedOrUpdated", msg) | ||
case *appprotectdos.DosPolicyEx: | ||
msg := "Configuration was added or updated" | ||
lbc.recorder.Event(impl.Obj, api_v1.EventTypeNormal, "AddedOrUpdated", msg) | ||
case *appprotectdos.DosLogConfEx: | ||
eventType := api_v1.EventTypeNormal | ||
eventTitle := "AddedOrUpdated" | ||
msg := "Configuration was added or updated" | ||
if impl.ErrorMsg != "" { | ||
msg += fmt.Sprintf(" ; with warning(s): %s", impl.ErrorMsg) | ||
eventTitle = "AddedOrUpdatedWithWarning" | ||
eventType = api_v1.EventTypeWarning | ||
} | ||
lbc.recorder.Event(impl.Obj, eventType, eventTitle, msg) | ||
} | ||
} else if c.Op == appprotectdos.Delete { | ||
switch impl := c.Resource.(type) { | ||
case *appprotectdos.DosPolicyEx: | ||
lbc.configurator.DeleteAppProtectDosPolicy(impl.Obj) | ||
|
||
case *appprotectdos.DosLogConfEx: | ||
lbc.configurator.DeleteAppProtectDosLogConf(impl.Obj) | ||
|
||
case *appprotectdos.DosProtectedResourceEx: | ||
glog.V(3).Infof("handling change DELETE for DOS protected %s/%s", impl.Obj.Namespace, impl.Obj.Name) | ||
resources := lbc.configuration.FindResourcesForAppProtectDosProtected(impl.Obj.Namespace, impl.Obj.Name) | ||
resourceExes := lbc.createExtendedResources(resources) | ||
warnings, err := lbc.configurator.AddOrUpdateResourcesThatUseDosProtected(resourceExes.IngressExes, resourceExes.MergeableIngresses, resourceExes.VirtualServerExes) | ||
lbc.updateResourcesStatusAndEvents(resources, warnings, err) | ||
} | ||
} | ||
} | ||
} | ||
|
||
func (lbc *LoadBalancerController) processAppProtectDosProblems(problems []appprotectdos.Problem) { | ||
glog.V(3).Infof("Processing %v App Protect Dos problems", len(problems)) | ||
|
||
for _, p := range problems { | ||
eventType := api_v1.EventTypeWarning | ||
lbc.recorder.Event(p.Object, eventType, p.Reason, p.Message) | ||
} | ||
} | ||
|
||
func (lbc *LoadBalancerController) cleanupUnwatchedAppDosResources(nsi *namespacedInformer) { | ||
for _, obj := range nsi.appProtectDosPolicyLister.List() { | ||
dosPol := obj.((*unstructured.Unstructured)) | ||
namespace := dosPol.GetNamespace() | ||
name := dosPol.GetName() | ||
|
||
changes, problems := lbc.dosConfiguration.DeletePolicy(namespace + "/" + name) | ||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
for _, obj := range nsi.appProtectDosProtectedLister.List() { | ||
dosPol := obj.((*unstructured.Unstructured)) | ||
namespace := dosPol.GetNamespace() | ||
name := dosPol.GetName() | ||
|
||
changes, problems := lbc.dosConfiguration.DeleteProtectedResource(namespace + "/" + name) | ||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
for _, obj := range nsi.appProtectDosLogConfLister.List() { | ||
dosPol := obj.((*unstructured.Unstructured)) | ||
namespace := dosPol.GetNamespace() | ||
name := dosPol.GetName() | ||
|
||
changes, problems := lbc.dosConfiguration.DeleteLogConf(namespace + "/" + name) | ||
lbc.processAppProtectDosChanges(changes) | ||
lbc.processAppProtectDosProblems(problems) | ||
} | ||
} |
Oops, something went wrong.