Skip to content

Enable/Disable Features #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: v3
Choose a base branch
from
Open

Enable/Disable Features #1051

wants to merge 9 commits into from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 18, 2025

Proposed changes

Added enable disable features check

  • Added logs informing user that feature is disabled and whats features are enabled
  • Removed Connection feature as most other features are not usable without it
  • Otel Plugin no longer starts if metrics feature is disabled
  • Certificates feature is now checked when parsing the nginx config, if feature is disabled we skip the cert

Features:
FeatureConfiguration = Default ON
FeatureMetrics = Default ON
FeatureFileWatcher = Default ON
FeatureAPIAction = Default OFF
FeatureLogsNap = Default OFF
FeatureCertificates = Default OFF

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Apr 18, 2025
@aphralG aphralG requested a review from a team as a code owner April 18, 2025 09:53
@github-actions github-actions bot added chore Pull requests for routine tasks enhancement New feature or request labels Apr 18, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 18, 2025
},
},
{
name: "Test 7: All features enabled",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Test 5 instead of 7, I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants