This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Add support for usage on https site #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 26, 2015 13:55
Merged
|
My apologies for not replying to this sooner. We'll be reviewing issues and pull requests. You should see movement on this soon. |
| } | ||
| provider = $.fn.oembed.getOEmbedProvider(resourceURL); |
There was a problem hiding this comment.
This line will never fire, you're already ensuring there isn't a provider based on the resourceURL. Safe to remove this.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code could not be used on a site with https: protocol as providers urls were http: prefixed. Did not go through all services if the have https support though, but the mayor ones seemed to work.
Also added qUnit tests for vimeo and youtube. (can re-write to jasmine if it is preferred).
If testing for services is ok by You, then probably should extend these to all available services so api changes/breakdown monitoring can be automated.