Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI interface of Swate - Templates #610

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Conversation

Etschbeijer
Copy link
Collaborator

Closes Issue #606

@Etschbeijer Etschbeijer self-assigned this Jan 28, 2025
@Etschbeijer
Copy link
Collaborator Author

grafik
Add empty scrollbar, that is filled when needed
ExcelSwateTopLevelMetadataShowcase18102024PB

@Etschbeijer
Copy link
Collaborator Author

ExcelSwateTopLevelMetadataShowcase18102024PB

@Etschbeijer Etschbeijer marked this pull request as ready for review January 31, 2025 09:54
Daisy.collapseTitle [
prop.className "p-1 min-h-0 h-5 text-sm"
prop.text (if isActive then "Select Columns" else "Preview Table")
prop.className "p-1 min-h-0 h-5 collapse-title text-success text-sm font-bold space-x-2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you are doing "collapse-title" twice. This should already be applied by the helper "Daisy.collapseTitle"

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Freymaurer Freymaurer merged commit 9c15981 into main Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants