Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete project structure rework #330

Merged
merged 64 commits into from
Apr 3, 2024
Merged

Complete project structure rework #330

merged 64 commits into from
Apr 3, 2024

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Mar 21, 2024 •
edited by Freymaurer
Loading

soon™

Closes #157
Closes #285

floWetzels and others added 30 commits March 21, 2024 14:14
@floWetzels @HLWeil
new ro-crate export and context files
9b0d7b7
@floWetzels @HLWeil
adapted json export tests for new ro-crate export (Investigation stil…
1cc83f8 
…l open)
@floWetzels @HLWeil
Added fromJsonldString for all ISA-JSON types. Also fixed some bugs.
5b0adba
@floWetzels @HLWeil
Updated tests for jsonld readers. Investigation test still wip.
e7b0015
@Freymaurer @HLWeil
WIP 🚧
9983642
@Freymaurer @HLWeil
WIP 🚧
280d3b8
@floWetzels @HLWeil
new ro-crate export and context files
d1cbba9
@floWetzels @HLWeil
adapted json export tests for new ro-crate export (Investigation stil…
d8c4d0a 
…l open)
@floWetzels @HLWeil
Updated tests for jsonld readers. Investigation test still wip.
f7beae7
@Freymaurer @HLWeil
WIP 🚧
3bf2a83
@Freymaurer @HLWeil
fix multiple issues with ro-crate json encoding 🐛
996ae0e
@Freymaurer @HLWeil
add addtionalType to ProcessParameterValue
dd69b1f
@HLWeil
move UIHelper function into compositecell
4b2b78f
@HLWeil
move all filesystem information into filesystem project
ceefce8
@HLWeil
restructure project
90520bd
@HLWeil
restructure ARCtrl.Core (former ARCtrl.ISA) project
b282dc3
@HLWeil
rework ARCtrl.Core types to improve transpiled javascript
2cb9db8
@HLWeil
rework ARCtrl.Spreadsheet according to datamodel changes
b568074
@HLWeil
start reworking ARCtrl.json project
f65d414
@Freymaurer
Start workin on new Json API layer 🚧
5150773
@HLWeil
fix arctrl.core tests
e053cd9
@HLWeil
start reworking arctrl.json process serialization
a29a7f9
@Freymaurer
Finish json for shared types ✨
6b670d9
@Freymaurer
Finish json table logic ✨
a51bfcc
@Freymaurer
finish up ISA-JSON conversion for process types ✨
f24259e
@Freymaurer
fix wrong encoder/decoder calls ✨
cd69fc3
@Freymaurer
Start with component logic rework 🚧
19b849a
@HLWeil
rework ROCrate process serialization
437bca3
@HLWeil
rework ARCAssay and ArcStudy ISAJson serialization
e710c5a
@Freymaurer
Start moving Arc Json logic 🚧
04b097b
Freymaurer and others added 19 commits March 26, 2024 11:09
@Freymaurer
Start working on tests 🚧
c193629
@HLWeil
fix arctrl.core tests and equality of reworked objects
6c9123e
@HLWeil
fix component name conversion
fbaa958
@Freymaurer
Add custom ToString for OntologyAnnotation 🎨
adac51c
@Freymaurer
More work on json tests 🚧
c885111
@HLWeil
reduce test spreadsheet metadata matching reduction of parser logic
cb5da3a
@Freymaurer
more work on json 🚧
4fc4a07
@HLWeil
move template json tests to json test project
3f35262
@HLWeil
move ARCtrl contract tests to Contract test project
766d46a
@HLWeil
move and fix spreadsheet Template tests
97c433e
@HLWeil
Template fixes against json and core tests
9da88fe
@HLWeil
start reworking tests for js and py
5803eb7
@HLWeil
move and fix template hashcode and equality tests
451ef11
@Freymaurer
Finish json (for now 🚧)
89f976c
@HLWeil
several python test fixes
d5eae8d
@Freymaurer
rmv leftover folder 🔥
18012b3
@Freymaurer
update github CI
8d50567
@Freymaurer
Make js native tests pass ✔️
e3512c7
@HLWeil
fix json parsing DateTime issues
b15a377
@HLWeil HLWeil marked this pull request as ready for review April 2, 2024 09:06
Freymaurer
Freymaurer approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;rtm

@HLWeil HLWeil merged commit fbe7265 into main Apr 3, 2024
2 checks passed
@HLWeil HLWeil deleted the arctrl_rework branch June 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freymaurer Freymaurer Freymaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HLWeil @Freymaurer @floWetzels