Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonld Export with new bioschemas types #321

Closed
wants to merge 4 commits into from
Closed

Conversation

floWetzels
Copy link
Collaborator

@floWetzels floWetzels commented Mar 13, 2024

This PR updates the jsonld/ro-crate export such that the output and contexts now use the new bioschemas types LabProcess and LabProtocol. Also, some structural changes were made to the jsonld output. The json decoders were changed accordingly, so that they can now read typical ISA-JSON or the new RO-Crate format. Each data type therefore has a fromJsonString and a fromJsonldString function.

The tests were adapted accordingly. However, they are not yet finished. The InvestigationLD tests need to be updated, since the current expected json strings are still using the old structure and terms. Furthermore, a new OutputMatchesInputLDtoLD test was added in the ProcessLD test list that reads the new jsonld string, writes it again and then checks for equality. Such tests should be added for all types (the existing ones read normal ISA-JSON and then write jsonld). @HLWeil pleas add/update these tests before merging.

Another part that needs revision are the readers for Material/Sample/Source. Currently, the type is not determined correctly when reading jsonld. The test ProcessInputLD - Sample - ReaderSuccessSimple is deactivated therefore.

@HLWeil
Copy link
Member

HLWeil commented Mar 23, 2024

Closing in favor of #330

@HLWeil HLWeil closed this Mar 23, 2024
@HLWeil HLWeil deleted the new_json_export branch May 31, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants