Jsonld Export with new bioschemas types #321
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the jsonld/ro-crate export such that the output and contexts now use the new bioschemas types LabProcess and LabProtocol. Also, some structural changes were made to the jsonld output. The json decoders were changed accordingly, so that they can now read typical ISA-JSON or the new RO-Crate format. Each data type therefore has a
fromJsonString
and afromJsonldString
function.The tests were adapted accordingly. However, they are not yet finished. The
InvestigationLD
tests need to be updated, since the current expected json strings are still using the old structure and terms. Furthermore, a newOutputMatchesInputLDtoLD
test was added in theProcessLD
test list that reads the new jsonld string, writes it again and then checks for equality. Such tests should be added for all types (the existing ones read normal ISA-JSON and then write jsonld). @HLWeil pleas add/update these tests before merging.Another part that needs revision are the readers for Material/Sample/Source. Currently, the type is not determined correctly when reading jsonld. The test
ProcessInputLD - Sample - ReaderSuccessSimple
is deactivated therefore.