Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified CLI arguments help in IArgParserTemplate #231

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

cmohl2013
Copy link
Contributor

Modification of docstrings.

When registering protocols with ARCCommander I had a hard time to find out, that e.g. ParametersTermAccssionNumber has to be set as a semicolon delimited list of the same lengths as ParametersName.

I therefore propose the following modifications of the CLI help.

Best regards
Christoph

The error message could also be a bit more specific:

Start Protocol Register 
Done processing command. 
ERROR: System.Exception: The length of the aggregated string tt does not match the length of the others System.Exception: The length of the aggregated string tt does not match the length of the others
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1448.Invoke(String message)
   at Microsoft.FSharp.Collections.ArrayModule.Fold[T,TState](FSharpFunc`2 folder, TState state, T[] array) in D:\a\_work\1\s\src\FSharp.Core\array.fs:line 1351
   at ISADotNet.XLSX.Component.fromAggregatedStrings(Char separator, String names, String terms, String source, String accessions)
   at ISADotNet.XLSX.Protocols.fromString(String name, String protocolType, String typeTermAccessionNumber, String typeTermSourceREF, String description, String uri, String version, String parametersName, String parametersTermAccessionNumber, String parametersTermSourceREF, String componentsName, String componentsType, String componentsTypeTermAccessionNumber, String componentsTypeTermSourceREF, FSharpList`1 comments)
   at ArcCommander.APIs.StudyAPI.Protocols.register(ArcConfiguration arcConfiguration, FSharpMap`2 protocolArgs)
   at [email protected](ArcConfiguration arcConfiguration, FSharpMap`2 protocolArgs)
   at ArcCommander.Program.processCommand[a,T](ArcConfiguration arcConfiguration, FSharpFunc`2 commandF, ParseResults`1 r)
   at ArcCommander.Program.handleStudyProtocolSubCommands(ArcConfiguration arcConfiguration, StudyProtocolCommand protocolVerb)
   at ArcCommander.Program.handleStudySubCommands(ArcConfiguration arcConfiguration, StudyCommand studyVerb)
   at ArcCommander.Program.handleCommand(ArcConfiguration arcConfiguration, ArcCommand command)
   at ArcCommander.Program.main(String[] argv)

Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good addition!

If you want, you could do the same addition to Person Roles in Study and Investigation.

@HLWeil HLWeil merged commit 8a4bf16 into nfdi4plants:developer Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants