Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in pipeline names #3067

Open
adamrtalbot opened this issue Jul 16, 2024 · 3 comments
Open

Allow numbers in pipeline names #3067

adamrtalbot opened this issue Jul 16, 2024 · 3 comments

Comments

@adamrtalbot
Copy link
Contributor

Description of feature

Currently, pipeline names do not allow numbers, even if the organisation (prefix) is not nf-core. We need to support this because many pipeline names include numbers outside of core nf-core pipelines.

@awgymer
Copy link
Contributor

awgymer commented Aug 7, 2024

I see this has been fixed in a PR, but I think it might need some refinement. Are we sure that names which start with a number are allowed? (Groovy/java variables can't and we use the name as the name of a workflow in nextflow).

Also is - definitely now usable? I tried it previously (more than a year ago) and again some stuff in the template borked because of it in variable names.

@adamrtalbot
Copy link
Contributor Author

I see this has been fixed in a PR, but I think it might need some refinement. Are we sure that names which start with a number are allowed? (Groovy/java variables can't and we use the name as the name of a workflow in nextflow).

Also is - definitely now usable? I tried it previously (more than a year ago) and again some stuff in the template borked because of it in variable names.

If you make a pipeline and you never try to run it once I think you have bigger problems than the name of your pipeline.

@awgymer
Copy link
Contributor

awgymer commented Aug 7, 2024

I think we should aim to stop people foot-gunning themselves wherever possible - it's part of the appeal of something like nf-core.

FWIW I have confirmed that names which start with a number or hyphen/dash cause errors:

- cause: Workflow definition syntax error -- A string identifier must be provided after the `workflow` keyword @ line 79, column 9.
   workflow 2TEST {
   
- cause: Workflow definition syntax error -- A string identifier must be provided after the `workflow` keyword @ line 79, column 9.
   workflow TEST-2 {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants