Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module updates #13

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Module updates #13

merged 2 commits into from
Jun 9, 2024

Conversation

nictru
Copy link
Collaborator

@nictru nictru commented Jun 9, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8a16b2c

+| ✅ 198 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗  14 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in main.nf: A stub section should mimic the execution of the original module as best as possible
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/base.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/configuration.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/macros.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/network.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/snp.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/tf.html
  • template_strings - Ignoring Jinja template strings in file /home/runner/work/tfactivity/tfactivity/modules/local/report/create/app/templates/tg.html

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-09 13:52:25

@nictru nictru requested a review from LeonHafner June 9, 2024 14:00
LeonHafner
LeonHafner approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@LeonHafner LeonHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating!

@nictru nictru merged commit ad4a112 into dev Jun 9, 2024
4 checks passed
@nictru nictru deleted the module-updates_24-06 branch June 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHafner LeonHafner LeonHafner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nictru @LeonHafner