Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #165

Open
wants to merge 350 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
350 commits
Select commit Hold shift + click to select a range
18726fe
Merge branch 'dev' into nf-core-template-merge-2.12
maxulysse Feb 1, 2024
ce95d67
fix schema
maxulysse Feb 1, 2024
c226ebe
template logo
maxulysse Feb 1, 2024
06d30fe
update .editorconfig
maxulysse Feb 1, 2024
ccce756
prettier
maxulysse Feb 1, 2024
9f45743
editor config
maxulysse Feb 1, 2024
ca46c28
logo from template
maxulysse Feb 1, 2024
ebb949b
Merge pull request #120 from nf-core/nf-core-template-merge-2.12
maxulysse Feb 2, 2024
e5493bb
Fixed S3 bucket path in conditional statements
nschcolnicov Feb 8, 2024
557d23f
Updated Changelog
nschcolnicov Feb 8, 2024
a42bb7e
[automated] Fix linting with Prettier
nf-core-bot Feb 12, 2024
dc05d53
Merge pull request #124 from nschcolnicov/dev
maxulysse Feb 12, 2024
0429e57
Merge pull request #106 from nf-core/bounlu-patch-2
maxulysse Feb 12, 2024
111e322
Fixed VEP s3 bucket path
nschcolnicov Feb 15, 2024
3de9b74
Updated changelog with PR
nschcolnicov Feb 15, 2024
d47e3ff
Merge pull request #127 from nschcolnicov/fix_vep
maxulysse Feb 15, 2024
36755fe
Added missing defs
nschcolnicov Feb 20, 2024
1462823
Modified Changelog
nschcolnicov Feb 20, 2024
7a3bef9
Updated readme
nschcolnicov Feb 20, 2024
80f755c
Update CHANGELOG.md
nschcolnicov Feb 20, 2024
37282c4
Template update for nf-core/tools version 2.13
nf-core-bot Feb 20, 2024
9036f17
Merge pull request #130 from nschcolnicov/fix_multi_sample
maxulysse Feb 20, 2024
f22ec03
Fixed null value in publish dir
nschcolnicov Feb 21, 2024
07dee64
Merge pull request #132 from nschcolnicov/fix_publish_dir
maxulysse Feb 22, 2024
a31daa6
Template update for nf-core/tools version 2.13.1
nf-core-bot Feb 29, 2024
83fef7b
Replaced UNZIP with GUNZIP
nschcolnicov Mar 19, 2024
4438535
Updated changelog, removed unnecesary module, not in use
nschcolnicov Mar 19, 2024
45c2b2a
Merge pull request #136 from nschcolnicov/fix_unzip
maxulysse Mar 19, 2024
02d4825
Modification for indexation on gvcf
MathieuCharlesINRAE Mar 21, 2024
62e673d
Merge branch 'dev' into gvcf
maxulysse Apr 4, 2024
eb25240
restore old version of subworkflow
maxulysse Apr 4, 2024
2d3ef4d
code polish
maxulysse Apr 4, 2024
0b1a7a4
code polish
maxulysse Apr 4, 2024
3605063
code polish
maxulysse Apr 4, 2024
b0fac8f
Template update for nf-core/tools version 2.14.0
nf-core-bot May 8, 2024
11b5cfc
Template update for nf-core/tools version 2.14.1
nf-core-bot May 9, 2024
886731c
Merge branch 'dev' into gvcf
maxulysse May 27, 2024
c0981be
merge 137
maxulysse May 27, 2024
1757309
Apply suggestions from code review
maxulysse May 27, 2024
50bdead
prettier
maxulysse May 27, 2024
e7943b8
lint
maxulysse May 27, 2024
8be8b3e
fix merge conflicts
maxulysse May 27, 2024
3f028a8
fix merge conflicts
maxulysse May 27, 2024
fb2586a
fix linting
maxulysse May 27, 2024
0ef4c85
update contributors
maxulysse May 27, 2024
66a151a
update contributors
maxulysse May 27, 2024
a833135
Merge pull request #138 from maxulysse/gvcf
maxulysse May 27, 2024
a0a1f69
Merge branch 'dev' into nf-core-template-merge-2.14.1
maxulysse May 28, 2024
dfc2220
remove custom_dumpsoftwareversions
maxulysse May 28, 2024
4cf692f
fix linting
maxulysse May 28, 2024
7885146
more linting updates
maxulysse May 28, 2024
4f1b40a
fix path
maxulysse May 28, 2024
b1891a8
Update assets/schema_input.json
maxulysse May 28, 2024
3bce902
fix path
maxulysse May 28, 2024
7c05e35
update CHANGELOG
maxulysse May 28, 2024
51790a2
fix syntax errors (and a couple of extra stuff)
maxulysse May 28, 2024
2123303
fix version
maxulysse May 28, 2024
957ea68
update all modules
maxulysse May 29, 2024
233361c
update subworkflows
maxulysse May 29, 2024
993b259
proper align
maxulysse May 29, 2024
3f15db6
fix workflow
maxulysse May 29, 2024
d95d300
fix expected test outputs
maxulysse May 29, 2024
48cb638
Merge pull request #140 from nf-core/nf-core-template-merge-2.14.1
maxulysse May 29, 2024
a8a5172
fix dbsnp usage
maxulysse May 31, 2024
74192be
update CHANGELOG
maxulysse May 31, 2024
5be1981
fix dbsnp usage
maxulysse May 31, 2024
358c6ff
fix dbsnp usage
maxulysse May 31, 2024
4e9fb0e
Merge pull request #142 from maxulysse/fix_dbsnp_known_indels_usage
maxulysse May 31, 2024
a118f1d
add contig ignore to beintervals
maxulysse Jun 3, 2024
14895d2
update CHANGELOG
maxulysse Jun 10, 2024
2c708c0
Merge pull request #143 from maxulysse/bedintervals
maxulysse Jun 10, 2024
08240b5
Change gatk_vf params from integer to floats
robsyme Jun 17, 2024
0b2c66e
Merge pull request #144 from nf-core/filter-default-fix
maxulysse Jun 17, 2024
c52ab26
Updated ch_gtf channel in main.nf
nschcolnicov Jun 26, 2024
ccd9d82
Updated ch_fasta_fai channel
nschcolnicov Jun 26, 2024
e563727
Merge pull request #149 from nschcolnicov/dev
maxulysse Jun 27, 2024
383d4b5
Template update for nf-core/tools version 3.0.0
nf-core-bot Oct 8, 2024
accb109
Template update for nf-core/tools version 3.0.1
nf-core-bot Oct 9, 2024
0fa9c17
Updated ch_gtf channel in main.nf
nschcolnicov Jun 26, 2024
b54c8a2
Updated ch_fasta_fai channel
nschcolnicov Jun 26, 2024
f8ad5f4
Merge branch 'dev' into nf-core-template-merge-3.0.1
maxulysse Oct 11, 2024
7b3a38e
Merge branch 'dev' into nf-core-template-merge-3.0.1
maxulysse Oct 11, 2024
4c58044
fix schema and channels
maxulysse Oct 11, 2024
b096e05
create tests
maxulysse Oct 11, 2024
c143e9c
Template update for nf-core/tools version 3.0.2
nf-core-bot Oct 11, 2024
732ee1b
create tests
maxulysse Oct 11, 2024
6e7344d
just pipeline tests
maxulysse Oct 11, 2024
f1aa3f9
fix linting with gitignore
maxulysse Oct 11, 2024
d458ffe
Merge branch 'nf-core-template-merge-3.0.1' into nf-core-template-mer…
maxulysse Oct 11, 2024
66dd5b5
Apply suggestions from code review
maxulysse Oct 11, 2024
370ba86
Merge pull request #153 from nf-core/nf-core-template-merge-3.0.2
maxulysse Oct 11, 2024
9915cc7
convert reference channels from queue to value channel
fmalmeida Nov 15, 2024
25103d3
Merge pull request #154 from nf-core/145-dev-branch-works-only-on-the…
maxulysse Nov 19, 2024
46c8922
Template update for nf-core/tools version 3.1.0
nf-core-bot Dec 12, 2024
25295ff
Template update for nf-core/tools version 3.1.1
nf-core-bot Dec 20, 2024
cebbe92
update samplesheet schema
nvnieuwk Jan 7, 2025
eed191f
add bam and cram samplesheet
nvnieuwk Jan 7, 2025
7f27a52
add new subwf prepare_alignment
nvnieuwk Jan 7, 2025
c52c360
finish up the implementation
nvnieuwk Jan 7, 2025
a9ec02d
fix wrong fai input in markduplicates
nvnieuwk Jan 7, 2025
aff0de8
fix and add tests
nvnieuwk Jan 7, 2025
d9534bf
update docs & changelog
nvnieuwk Jan 7, 2025
c788544
fix snapshots
nvnieuwk Jan 8, 2025
afd9ff2
Merge pull request #157 from nvnieuwk/add-bam/cram-support
nvnieuwk Jan 8, 2025
ecdf0a0
fix conf and main workflows
nvnieuwk Jan 8, 2025
43eda7d
fix local subwfs
nvnieuwk Jan 8, 2025
77dc247
fix subwfs
nvnieuwk Jan 9, 2025
bcaaee9
fix configs
nvnieuwk Jan 9, 2025
a0813de
prettier
nvnieuwk Jan 9, 2025
7b15774
let everything run again
nvnieuwk Jan 9, 2025
5c095be
Update workflows/rnavar/main.nf
nvnieuwk Jan 9, 2025
d1b409d
remove verbose and debug from nf-test ci (real errors were being crop…
nvnieuwk Jan 9, 2025
717ca2a
remove ch_ prefix
nvnieuwk Jan 9, 2025
f54266e
fix some tests
nvnieuwk Jan 9, 2025
ceeb934
fix snapshots
nvnieuwk Jan 9, 2025
64950b7
Update subworkflows/local/prepare_genome/main.nf
nvnieuwk Jan 9, 2025
8a69313
update changelog
nvnieuwk Jan 10, 2025
8164c37
Merge branch 'fix/language-server' of github.com:nvnieuwk/nf-core-rna…
nvnieuwk Jan 10, 2025
b422fbc
add this PR
nvnieuwk Jan 10, 2025
cbb4b84
Merge pull request #158 from nvnieuwk/fix/language-server
nvnieuwk Jan 10, 2025
3addcd3
fix join bottlenecks
nvnieuwk Jan 13, 2025
ec57401
fix a groupTuple bottleneck
nvnieuwk Jan 13, 2025
ad1f1bc
fix splitcigarreads groupTuple bottleneck
nvnieuwk Jan 13, 2025
8037ce7
update changelog
nvnieuwk Jan 13, 2025
0d2bb33
make editorconfig happy
nvnieuwk Jan 13, 2025
8ef0e65
Update subworkflows/local/splitncigar/main.nf
nvnieuwk Jan 14, 2025
d477c21
Update subworkflows/local/splitncigar/main.nf
nvnieuwk Jan 14, 2025
0c18809
Update workflows/rnavar/main.nf
nvnieuwk Jan 15, 2025
4035a18
Update subworkflows/local/splitncigar/main.nf
nvnieuwk Jan 15, 2025
bfd3665
Merge pull request #159 from nvnieuwk/fix/bottlenecks
nvnieuwk Jan 15, 2025
5d3e90d
Merge remote-tracking branch 'origin/dev' into nf-core-template-merge…
nvnieuwk Jan 15, 2025
a2c61fd
fix tests
nvnieuwk Jan 15, 2025
557f18e
fix linting
nvnieuwk Jan 15, 2025
aee62f0
add report param
nvnieuwk Jan 15, 2025
02005bd
Update nextflow.config
nvnieuwk Jan 15, 2025
eb35f24
Merge pull request #156 from nf-core/nf-core-template-merge-3.1.1
nvnieuwk Jan 15, 2025
b9ad480
Template update for nf-core/tools version 3.1.2
nf-core-bot Jan 20, 2025
06c1f6c
Template update for nf-core/tools version 3.2.0
nf-core-bot Jan 27, 2025
8de13cd
Merge remote-tracking branch 'origin/dev' into nf-core-template-merge…
nvnieuwk Feb 20, 2025
008d464
fix multiqc lint error
nvnieuwk Feb 20, 2025
ca99259
bump changelog
nvnieuwk Feb 20, 2025
3690cae
Merge pull request #161 from nf-core/nf-core-template-merge-3.2.0
nvnieuwk Feb 20, 2025
04b4d6a
remove strandedness
nvnieuwk Feb 21, 2025
8e71d65
update changelog
nvnieuwk Feb 21, 2025
478df07
Merge pull request #167 from nvnieuwk/remove/strandedness
maxulysse Feb 23, 2025
07da1a1
allow integer vep_cache_version
nvnieuwk Feb 24, 2025
ab75117
allow integer snpeff_db
nvnieuwk Feb 24, 2025
0881a64
update changelog
nvnieuwk Feb 24, 2025
ca89dff
Merge pull request #168 from nvnieuwk/fix/string-integers
nvnieuwk Feb 24, 2025
c8335c1
add `--star_max_intron_size`
nvnieuwk Feb 24, 2025
cf69982
update changelog
nvnieuwk Feb 24, 2025
16eb59f
Merge pull request #169 from nvnieuwk/add/star_max_intron_size
nvnieuwk Feb 24, 2025
b155b11
fix --skip_intervallisttools
nvnieuwk Feb 24, 2025
761440b
update changelog
nvnieuwk Feb 24, 2025
13821ee
added a missing check
nvnieuwk Feb 24, 2025
889f12c
Merge pull request #170 from nvnieuwk/fix/skip_intervallisttools
nvnieuwk Feb 24, 2025
b725e35
rework dbsnp handling and implement bgzip of dbsnp
nvnieuwk Feb 24, 2025
439a7b0
rework known_indels handling and allow uncompressed files
nvnieuwk Feb 24, 2025
4576a78
update changelog
nvnieuwk Feb 24, 2025
dc3c008
update the params schema
nvnieuwk Feb 24, 2025
ecfe4fc
small improvement to known indels description
nvnieuwk Feb 24, 2025
c073e24
add a missing .collect
nvnieuwk Feb 24, 2025
4ea81c2
first batch of schema updates
nvnieuwk Feb 24, 2025
37f64fe
update snapshots
nvnieuwk Feb 24, 2025
84cafed
second batch of schema updates
nvnieuwk Feb 24, 2025
2c4e924
Merge pull request #172 from nvnieuwk/fix/params-schema
nvnieuwk Feb 24, 2025
dcb07f1
Merge branch 'dev' into fix/dbsnp-handling
nvnieuwk Feb 24, 2025
9334b8a
Merge pull request #171 from nvnieuwk/fix/dbsnp-handling
nvnieuwk Feb 24, 2025
6cb4be3
add star index error handling
nvnieuwk Feb 25, 2025
298b502
update changelog
nvnieuwk Feb 25, 2025
d69e4d8
don't output untar output
nvnieuwk Feb 25, 2025
b8ee144
also test functions
nvnieuwk Feb 25, 2025
9876aa5
fix linting
nvnieuwk Feb 25, 2025
6709df0
don't output star index version output
nvnieuwk Feb 25, 2025
e5adc8c
fix tests
nvnieuwk Feb 25, 2025
fc885a1
Merge pull request #173 from nvnieuwk/fix/star-index-mismatch
nvnieuwk Feb 25, 2025
f0026c6
first steps to gff handling fixes
nvnieuwk Feb 25, 2025
c6c4ff0
Merge branch 'dev' into fix/gff-handling
nvnieuwk Feb 25, 2025
cfb156b
update cat/fastq
nvnieuwk Feb 27, 2025
6985871
correctly handle more ref data
nvnieuwk Feb 27, 2025
9072f4a
fix some edge cases
nvnieuwk Feb 27, 2025
4ae9887
update changelog
nvnieuwk Feb 27, 2025
60f61a6
move test data + fix snapshots
nvnieuwk Feb 27, 2025
5228dc2
fix more issues with tests
nvnieuwk Feb 27, 2025
ad56716
fix snapshot
nvnieuwk Feb 27, 2025
9cbd53b
Merge pull request #175 from nvnieuwk/fix/gff-handling
nvnieuwk Feb 27, 2025
d7b83c7
add exon bed filter step (credits to @Shaun-Regenbaum)
nvnieuwk Feb 27, 2025
deb39f7
update changelog
nvnieuwk Feb 27, 2025
2506c94
implement automatic sharding for nf-test
maxulysse Feb 27, 2025
d36fd58
implement automatic sharding for nf-test
maxulysse Feb 27, 2025
dc1da86
update nf-test.config file
maxulysse Feb 27, 2025
85b9d23
add missing file
maxulysse Feb 27, 2025
02701ea
fix linting
maxulysse Feb 27, 2025
8097e66
update CHANGELOG
maxulysse Feb 27, 2025
44dd7d4
better name for tests
maxulysse Feb 27, 2025
ba040db
fix snapshots
nvnieuwk Feb 28, 2025
ad0af7f
Merge pull request #177 from nvnieuwk/filter-exon-bed
nvnieuwk Feb 28, 2025
a99d6ce
Merge branch 'dev' into nf-test-automatic-shard
nvnieuwk Feb 28, 2025
1d5d5b2
fix s3 file resolving
nvnieuwk Feb 28, 2025
7312c7e
Merge pull request #179 from nvnieuwk/fix/file-resolving
maxulysse Feb 28, 2025
e8281bd
Update README.md
maxulysse Mar 3, 2025
ba09a02
Add UMI extraction
nvnieuwk Mar 3, 2025
04a5f22
update changelog
nvnieuwk Mar 3, 2025
756293c
update actions/cache
nvnieuwk Mar 3, 2025
05a5eb9
add tests
nvnieuwk Mar 3, 2025
ef007d3
Merge pull request #180 from nvnieuwk/add/umitools
nvnieuwk Mar 3, 2025
36350b9
bump all modules
nvnieuwk Mar 3, 2025
5427d17
fix workflow
nvnieuwk Mar 3, 2025
5a0a698
fix snpeff download input
nvnieuwk Mar 3, 2025
5466f3c
fix order when no star index has been given
nvnieuwk Mar 3, 2025
804e0e4
update snapshots
nvnieuwk Mar 3, 2025
9ed8106
Merge branch 'bump/modules' of https://github.com/nvnieuwk/nf-core-rn…
nvnieuwk Mar 3, 2025
0ef2590
bump changelog
nvnieuwk Mar 3, 2025
c9d56dd
Merge branch 'dev' into nf-test-automatic-shard
maxulysse Mar 3, 2025
ba15233
Merge pull request #182 from nvnieuwk/bump/modules
nvnieuwk Mar 4, 2025
5f00f46
Merge branch 'dev' into nf-test-automatic-shard
maxulysse Mar 4, 2025
e84ea35
fixed dbsnp and known_indels error handling
nvnieuwk Mar 4, 2025
9149f72
update changelog
nvnieuwk Mar 4, 2025
13ebf3a
Merge pull request #184 from nvnieuwk/optional/dbsnp-known_indels
maxulysse Mar 4, 2025
346a6a7
update modules.config
maxulysse Mar 3, 2025
d48306b
WIP
maxulysse Mar 4, 2025
379e79c
keep config the same
maxulysse Mar 4, 2025
3c338d5
properly ignore tests
maxulysse Mar 4, 2025
d956911
properly ignore tests
maxulysse Mar 4, 2025
0d3cd0f
Merge pull request #178 from maxulysse/nf-test-automatic-shard
maxulysse Mar 4, 2025
9173ddc
update README
nvnieuwk Mar 4, 2025
d93caff
Merge branch 'dev' into docs
nvnieuwk Mar 4, 2025
0343d5a
remove unused file
nvnieuwk Mar 4, 2025
23e3aff
update citations
nvnieuwk Mar 4, 2025
a85e4cc
update usage docs
nvnieuwk Mar 4, 2025
8a4dbde
update output docs
nvnieuwk Mar 4, 2025
afa81dd
changelog
nvnieuwk Mar 4, 2025
ad4db75
Update CITATIONS.md
nvnieuwk Mar 4, 2025
e9297af
add nvnieuwk to nextflow.config
nvnieuwk Mar 4, 2025
db4410b
add vcf_annotate_all tests
nvnieuwk Mar 4, 2025
006610f
remove comments
nvnieuwk Mar 4, 2025
bbd2eca
add splitncigar tests
nvnieuwk Mar 4, 2025
99ef03a
test recalibrate
nvnieuwk Mar 5, 2025
47c0f42
test prepare_genome
nvnieuwk Mar 5, 2025
6ea6d5f
test prepare_alignment
nvnieuwk Mar 5, 2025
62f742c
test cram_qc_mosdepth_samtools
nvnieuwk Mar 5, 2025
c0778fc
test gtf2bed
nvnieuwk Mar 5, 2025
a34755e
test remove_unknown_regions
nvnieuwk Mar 5, 2025
e04af45
changelog
nvnieuwk Mar 5, 2025
69f190f
correctly run tests
nvnieuwk Mar 5, 2025
b469d13
update snpeff/snpeff
nvnieuwk Mar 5, 2025
6560d67
Merge pull request #187 from nvnieuwk/add/more-tests
maxulysse Mar 6, 2025
24828c1
Merge pull request #185 from nvnieuwk/docs
maxulysse Mar 6, 2025
56bd9df
fix issue with star index being queue channel
nvnieuwk Mar 6, 2025
de8326d
Merge pull request #190 from nvnieuwk/fix/multiple-fastqs
maxulysse Mar 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 20 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
}
}
15 changes: 14 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,20 @@ end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
indent_size = unset
[/subworkflows/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset

[/assets/email*]
indent_size = unset

# ignore python and markdown
[*.{py,md}]
indent_style = unset

# ignore ro-crate metadata files
[**/ro-crate-metadata.json]
insert_final_newline = unset
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.config linguist-language=nextflow
*.nf.test linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
48 changes: 35 additions & 13 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# nf-core/rnavar: Contributing Guidelines
# `nf-core/rnavar`: Contributing Guidelines

Hi there!
Many thanks for taking an interest in improving nf-core/rnavar.
Expand All @@ -9,6 +9,7 @@ Please use the pre-filled template to save time.
However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> [!NOTE]
> If you need help using or modifying nf-core/rnavar then the best place to ask is on the nf-core Slack [#rnavar](https://nfcore.slack.com/channels/rnavar) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Contribution workflow
Expand All @@ -18,13 +19,19 @@ If you'd like to write some code for nf-core/rnavar, the standard workflow is as
1. Check that there isn't already an issue about your idea in the [nf-core/rnavar issues](https://github.com/nf-core/rnavar/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/rnavar repository](https://github.com/nf-core/rnavar) to your GitHub account
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).

## Tests

You have the option to test your changes locally by running the pipeline. For receiving warnings about process selectors and other `debug` information, it is recommended to use the debug profile. Execute all the tests with the following command:

```bash
nf-test test --profile debug,test,docker --verbose
```

When you create a pull request with changes, [GitHub Actions](https://github.com/features/actions) will run automatic tests.
Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.

Expand All @@ -33,7 +40,7 @@ There are typically two types of tests that run:
### Lint tests

`nf-core` has a [set of guidelines](https://nf-co.re/developers/guidelines) which all pipelines must adhere to.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core lint <pipeline-directory>` command.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core pipelines lint <pipeline-directory>` command.

If any failures or warnings are encountered, please follow the listed URL for more documentation.

Expand All @@ -48,27 +55,27 @@ These tests are run both with the latest available version of `Nextflow` and als

:warning: Only in the unlikely and regretful event of a release happening with a bug.

- On your own fork, make a new branch `patch` based on `upstream/master`.
- On your own fork, make a new branch `patch` based on `upstream/main` or `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.
- Open a pull-request from `patch` to `main`/`master` with the changes.

## Getting help

For further information/help, please consult the [nf-core/rnavar documentation](https://nf-co.re/rnavar/usage) and don't hesitate to get in touch on the nf-core Slack [#rnavar](https://nfcore.slack.com/channels/rnavar) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Pipeline contribution conventions

To make the nf-core/rnavar code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.
To make the `nf-core/rnavar` code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.

### Adding a new step

If you wish to contribute a new step, please use the following coding standards:

1. Define the corresponding input channel into your new process from the expected previous process channel
1. Define the corresponding input channel into your new process from the expected previous process channel.
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core schema build` tool).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core pipelines schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
Expand All @@ -77,15 +84,15 @@ If you wish to contribute a new step, please use the following coding standards:

### Default values

Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.
Parameters should be initialised / defined with default values within the `params` scope in `nextflow.config`.

Once there, use `nf-core schema build` to add to `nextflow_schema.json`.
Once there, use `nf-core pipelines schema build` to add to `nextflow_schema.json`.

### Default processes resource requirements

Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/master/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.
Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/main/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.

The process resources can be passed on to the tool dynamically within the process with the `${task.cpu}` and `${task.memory}` variables in the `script:` block.
The process resources can be passed on to the tool dynamically within the process with the `${task.cpus}` and `${task.memory}` variables in the `script:` block.

### Naming schemes

Expand All @@ -96,8 +103,23 @@ Please use the following naming schemes, to make it easy to understand what is g

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core bump-version --nextflow . [min-nf-version]`
If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core pipelines bump-version --nextflow . [min-nf-version]`

### Images and figures

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).

## GitHub Codespaces

This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.

To get started:

- Open the repo in [Codespaces](https://github.com/nf-core/rnavar/codespaces)
- Tools installed
- nf-core
- Nextflow

Devcontainer specs:

- [DevContainer config](.devcontainer/devcontainer.json)
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ body:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/rnavar pipeline documentation](https://nf-co.re/rnavar/usage)

- type: textarea
id: description
attributes:
Expand Down Expand Up @@ -42,9 +41,9 @@ body:
attributes:
label: System information
description: |
* Nextflow version _(eg. 21.10.3)_
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter or Charliecloud)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/rnavar _(eg. 1.1, 1.5, 1.8.2)_
7 changes: 4 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/rnav

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/rnavar/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/rnavar _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/rnavar/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/rnavar _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
Expand Down
66 changes: 66 additions & 0 deletions .github/actions/get-shards/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: "Get number of shards"
description: "Get the number of nf-test shards for the current CI job"
inputs:
max_shards:
description: "Maximum number of shards allowed"
required: true
paths:
description: "Component paths to test"
required: false
outputs:
shard:
description: "Array of shard numbers"
value: ${{ steps.shards.outputs.shard }}
total_shards:
description: "Total number of shards"
value: ${{ steps.shards.outputs.total_shards }}
runs:
using: "composite"
steps:
- name: Install nf-test
uses: nf-core/setup-nf-test@v1
with:
version: ${{ env.NFT_VER }}
- name: Get number of shards
id: shards
shell: bash
run: |
# Run nf-test with dynamic parameter
nftest_output=$(nf-test test \
--dry-run \
--profile +docker \
--filter function,workflow,pipeline \
--ci \
--changed-since HEAD^) || {
echo "nf-test command failed with exit code $?"
echo "Full output: $nftest_output"
exit 1
}
echo "nf-test dry-run output: $nftest_output"

# Default values for shard and total_shards
shard="[]"
total_shards=0

# Check if there are related tests
if echo "$nftest_output" | grep -q 'No tests to execute'; then
echo "No related tests found."
else
# Extract the number of related tests
number_of_shards=$(echo "$nftest_output" | sed -n 's|.*Executed \([0-9]*\) tests.*|\1|p')
if [[ -n "$number_of_shards" && "$number_of_shards" -gt 0 ]]; then
shards_to_run=$(( $number_of_shards < ${{ inputs.max_shards }} ? $number_of_shards : ${{ inputs.max_shards }} ))
shard=$(seq 1 "$shards_to_run" | jq -R . | jq -c -s .)
total_shards="$shards_to_run"
else
echo "Unexpected output format. Falling back to default values."
fi
fi

# Write to GitHub Actions outputs
echo "shard=$shard" >> $GITHUB_OUTPUT
echo "total_shards=$total_shards" >> $GITHUB_OUTPUT

# Debugging output
echo "Final shard array: $shard"
echo "Total number of shards: $total_shards"
114 changes: 114 additions & 0 deletions .github/actions/nf-test/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
name: "nf-test Action"
description: "Runs nf-test with common setup steps"
inputs:
profile:
description: "Profile to use"
required: true
shard:
description: "Shard number for this CI job"
required: true
total_shards:
description: "Total number of test shards(NOT the total number of matrix jobs)"
required: true
paths:
description: "Test paths"
required: true

runs:
using: "composite"
steps:
- name: Setup Nextflow
uses: nf-core/setup-nextflow@v2
with:
version: "${{ env.NXF_VERSION }}"

- name: Set up Python
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5
with:
python-version: "3.11"

- name: Install nf-test
uses: nf-core/setup-nf-test@v1
with:
version: "${{ env.NFT_VER }}"

- name: Setup apptainer
if: contains(inputs.profile, 'singularity')
uses: eWaterCycle/setup-apptainer@main

- name: Set up Singularity
if: contains(inputs.profile, 'singularity')
shell: bash
run: |
mkdir -p $NXF_SINGULARITY_CACHEDIR
mkdir -p $NXF_SINGULARITY_LIBRARYDIR

- name: Conda setup
if: ${{inputs.profile == 'conda'}}
uses: conda-incubator/setup-miniconda@505e6394dae86d6a5c7fbb6e3fb8938e3e863830 # v3
with:
auto-update-conda: true
conda-solver: libmamba
conda-remove-defaults: true

- name: Install pdiff
shell: bash
run: |
python -m pip install pdiff

# TODO Skip failing conda tests and document their failures
# https://github.com/nf-core/modules/issues/7017
- name: Run nf-test
shell: bash
env:
NFT_DIFF: ${{ env.NFT_DIFF }}
NFT_DIFF_ARGS: ${{ env.NFT_DIFF_ARGS }}
NFT_WORKDIR: ${{ env.NFT_WORKDIR }}
run: |
nf-test test \
--profile=+${{ inputs.profile }} \
--tap=test.tap \
--verbose \
--ci \
--shard ${{ inputs.shard }}/${{ inputs.total_shards }} \
--filter function,workflow,pipeline

# Save the absolute path of the test.tap file to the output
echo "tap_file_path=$(realpath test.tap)" >> $GITHUB_OUTPUT

- name: Generate test summary
if: always()
shell: bash
run: |
# Add header if it doesn't exist (using a token file to track this)
if [ ! -f ".summary_header" ]; then
echo "# 🚀 nf-test results" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "| Status | Test Name | Profile | Shard |" >> $GITHUB_STEP_SUMMARY
echo "|:------:|-----------|---------|-------|" >> $GITHUB_STEP_SUMMARY
touch .summary_header
fi

if [ -f test.tap ]; then
while IFS= read -r line; do
if [[ $line =~ ^ok ]]; then
test_name="${line#ok }"
# Remove the test number from the beginning
test_name="${test_name#* }"
echo "| ✅ | ${test_name} | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
elif [[ $line =~ ^not\ ok ]]; then
test_name="${line#not ok }"
# Remove the test number from the beginning
test_name="${test_name#* }"
echo "| ❌ | ${test_name} | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
fi
done < test.tap
else
echo "| ⚠️ | No test results found | ${{ inputs.profile }} | ${{ inputs.shard }}/${{ inputs.total_shards }} |" >> $GITHUB_STEP_SUMMARY
fi

- name: Clean up
if: always()
shell: bash
run: |
sudo rm -rf /home/ubuntu/tests/
Loading
Loading