Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrasts to dev merge #146

Closed
wants to merge 8 commits into from
Closed

Contrasts to dev merge #146

wants to merge 8 commits into from

Conversation

asmaali98
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 83e8ad3

+| ✅ 242 tests passed       |+
!| ❗   5 tests had warnings |!
-| ❌  19 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/WorkflowRnasplice.groovy
  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config default value incorrect: params.igenomes_base is set as s3://ngi-igenomes/igenomes in nextflow_schema.json but is s3://ngi-igenomes/igenomes/ in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_gene_expr is set as 6 in nextflow_schema.json but is 4 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_feature_expr is set as 0 in nextflow_schema.json but is 2 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_feature_prop is set as 0 in nextflow_schema.json but is 2 in nextflow.config.
  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - assets/email_template.html does not match the template
  • files_unchanged - assets/email_template.txt does not match the template
  • files_unchanged - assets/nf-core-rnasplice_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-rnasplice_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-rnasplice_logo_dark.png does not match the template
  • modules_config - conf/modules.config contains withName:CAT_ADDITIONAL_FASTA, but the corresponding process is not present in any of the Nextflow scripts.

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.3
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in WorkflowRnasplice.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • nfcore_yml - nf-core version not set in .nf-core.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-18 06:47:39

@asmaali98 asmaali98 closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmaali98 @GreetaS