Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value from miso_genes_file to prevent checking for false file #128

Merged
merged 1 commit into from
May 12, 2024

Conversation

adamrtalbot
Copy link

The default for miso_genes_file was set to None, a Python value. It should have been null or blank. This PR removes it.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

…se file

The default for miso_genes_file was set to `None`, a Python value. It should have been null or blank. This PR removes it.
@jma1991 jma1991 merged commit aab6219 into dev May 12, 2024
21 of 22 checks passed
@jma1991
Copy link
Collaborator

jma1991 commented May 12, 2024

Thanks @adamrtalbot for the fix, it will be merged into master in the next patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants