Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move read.table out of loop #121

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Move read.table out of loop #121

merged 1 commit into from
Feb 19, 2024

Conversation

jma1991
Copy link
Collaborator

@jma1991 jma1991 commented Feb 16, 2024

This hot fix address the issue described here

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jma1991 jma1991 mentioned this pull request Feb 16, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 7e2f498

+| ✅ 208 tests passed       |+
!| ❗   4 tests had warnings |!
-| ❌  17 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config default value incorrect: params.igenomes_base is set as s3://ngi-igenomes/igenomes in nextflow_schema.json but is s3://ngi-igenomes/igenomes/ in nextflow.config.
  • nextflow_config - Config default value incorrect: params.aligner is set as star in nextflow_schema.json but is star_salmon in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_gene_expr is set as 6 in nextflow_schema.json but is 4 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_feature_expr is set as 0 in nextflow_schema.json but is 2 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_samps_feature_prop is set as 0 in nextflow_schema.json but is 2 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.miso_genes is set as ENSG00000004961, ENSG00000005302 in nextflow_schema.json but is ENSG00000004961, ENSG00000005302, ENSG00000147403 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.miso_genes_file is set as None in nextflow_schema.json but is null in nextflow.config.
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - assets/email_template.html does not match the template
  • files_unchanged - assets/email_template.txt does not match the template
  • files_unchanged - assets/nf-core-rnasplice_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-rnasplice_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-rnasplice_logo_dark.png does not match the template
  • files_unchanged - pyproject.toml does not match the template

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.3
  • pipeline_todos - TODO string in WorkflowRnasplice.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-16 10:04:00

@jma1991 jma1991 merged commit be1e0f2 into nf-core:dev Feb 19, 2024
21 of 22 checks passed
@jma1991 jma1991 deleted the hotfix-splitting-files branch February 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jma1991