Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify pScreenAdjusted argument depending on analysis method #113

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

jma1991
Copy link
Collaborator

@jma1991 jma1991 commented Jan 8, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jan 8, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit fcf8a8d

+| ✅ 158 tests passed       |+
!| ❗   4 tests had warnings |!
-| ❌   4 tests failed       |-

❌ Test failures:

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.1
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnasplice.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-08 14:26:43

@jma1991 jma1991 merged commit 0e4d76f into nf-core:dev Jan 8, 2024
21 of 22 checks passed
@jma1991 jma1991 deleted the fix-dexseq-padjusted-param branch January 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant