Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release bump #95

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Post-release bump #95

merged 3 commits into from
Sep 9, 2024

Conversation

scwatts
Copy link
Collaborator

@scwatts scwatts commented Sep 9, 2024

  • apply the nf-core post-release bump
  • remove .bumpversion.cfg since its use is not compatible with this process

@scwatts scwatts added this to the Release 1.1.0 milestone Sep 9, 2024
@scwatts scwatts requested a review from charlesshale September 9, 2024 01:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @scwatts,

It looks like this pull-request is has been made against the nf-core/oncoanalyser master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/oncoanalyser dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c0a082b

+| ✅ 178 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_params - Schema param panel not found from nextflow config
  • schema_params - Schema param genome_version not found from nextflow config
  • schema_params - Schema param genome_type not found from nextflow config
  • schema_params - Schema param ref_data_hmf_data_path not found from nextflow config
  • schema_params - Schema param ref_data_panel_data_path not found from nextflow config
  • schema_params - Schema param ref_data_virusbreakenddb_path not found from nextflow config
  • schema_params - Schema param ref_data_hla_slice_bed not found from nextflow config

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-09 01:28:29

@scwatts scwatts changed the base branch from master to dev September 9, 2024 01:18
@scwatts
Remove .bumpversion.cfg
c0a082b 
Automated sematic version bumping isn't compatible with the nf-core
post-release process.
@scwatts
Copy link
Collaborator Author

scwatts commented Sep 9, 2024

Force pushing to correct branch checks

@scwatts scwatts merged commit a9b94fa into dev Sep 9, 2024
4 checks passed
@scwatts scwatts deleted the post-release-bump branch September 9, 2024 02:05
scwatts added a commit that referenced this pull request Oct 11, 2024
@scwatts
Merge pull request #95 from nf-core/post-release-bump
bdcb87d 
Post-release bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesshale charlesshale charlesshale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@scwatts @charlesshale