-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-test for ashlar #6931
base: master
Are you sure you want to change the base?
nf-test for ashlar #6931
Conversation
Co-authored-by: Simon Pearce <[email protected]>
Thanks for the review @SPPearce, I don't fully understand why the conda test is failing as the tool is on bioconda and deployed as a biocontainer. I would assume that's an issue. Should the conda test be skipped? |
There is presumably something inside the test_all.ome.tif file that is different between docker/singularity and conda. |
The issue I'm seeing is that the conda output matched the md5sum in the previous test, even though the environment definition was the same. |
I'm also noticing an issue with application of flat and dark field correction - should be looked into before merging. |
A short update, I've just tested and a newly built Seqera container with ASHLAR from bioconda produces the same outputs as the conda version, but I haven't yet found the precise reason for the difference. |
Migrate pytest to nf-test for ASHLAR
PR checklist
Closes #6895
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
--- CONDA fails tests - not reproducible between Docker - Conda?