Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add length_trim parameter to nextflow.config file #416

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add length_trim parameter to nextflow.config file #416

merged 3 commits into from
Sep 17, 2024

Conversation

geethavenk
Copy link
Contributor

@geethavenk geethavenk commented Sep 16, 2024 •
edited
Loading

Included a new parameter, length_trim, to allow users to specify the minimum acceptable read length after quality and adapter trimming. This enhancement provides greater flexibility in handling quality trimming.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@geethavenk geethavenk requested a review from a team as a code owner September 16, 2024 07:20
@geethavenk
Update CHANGELOG
1a10da6 
Details about the new param included under Pipeline Updates.
@geethavenk geethavenk mentioned this pull request Sep 17, 2024
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 5af05d6

+| ✅ 187 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-17 09:06:31

@sateeshperi sateeshperi added this to the 2.7.0 milestone Sep 17, 2024
@sateeshperi sateeshperi added the enhancement New feature or request label Sep 17, 2024
sateeshperi
sateeshperi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sateeshperi sateeshperi merged commit fc4f665 into nf-core:feat/workflow-updates Sep 17, 2024
6 checks passed
@sateeshperi sateeshperi mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger FelixKrueger was automatically assigned from nf-core/methylseq

Assignees

@geethavenk geethavenk

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@geethavenk @sateeshperi