Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usage of Fasta references for bwameth / samtools faidx #403

Merged
merged 3 commits into from
May 28, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse requested a review from a team as a code owner May 28, 2024 07:31
@maxulysse maxulysse changed the base branch from master to dev May 28, 2024 07:31
Copy link

github-actions bot commented May 28, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit d38c4b1

+| ✅ 212 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-28 08:08:42

@nf-core nf-core deleted a comment from github-actions bot May 28, 2024
@nf-core nf-core deleted a comment from github-actions bot May 28, 2024
Copy link

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxulysse maxulysse merged commit 32297ea into nf-core:dev May 28, 2024
33 checks passed
@maxulysse maxulysse deleted the fasta_references branch May 28, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants