Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(#392): Add boilerplate for tests #393

Merged
merged 7 commits into from
May 17, 2024
Merged

test(#392): Add boilerplate for tests #393

merged 7 commits into from
May 17, 2024

Conversation

edmundmiller
Copy link
Collaborator

Closes #392

@edmundmiller edmundmiller added this to the 2.7.0 milestone Mar 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit f36cbdf

+| ✅ 212 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-17 12:58:47

FelixKrueger and others added 5 commits March 30, 2024 17:46
@FelixKrueger
Update samplesheet.csv
825d441 
This should now have both unique samples and samples that need to be merged for both single-end and paired-end scenarios.
@FelixKrueger
Update samplesheet.csv
86b4f7b 
Switching R1 and R2 round for the last test merge, which should also work (both for merging and for processing even though it won't align in directional mode).
@maxulysse
fix paths
880e473
@maxulysse
fix: fix path to script
94a3856
@maxulysse
Merge branch 'dev' into fix/tech-reps
d1c5d0e
@maxulysse maxulysse marked this pull request as ready for review May 17, 2024 12:01
@maxulysse maxulysse requested a review from a team as a code owner May 17, 2024 12:01
FelixKrueger
FelixKrueger approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@FelixKrueger FelixKrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very familiar with the tests (tests for Bismark output files appear to be missing?), but the samplesheet looks GTM.

@FelixKrueger FelixKrueger merged commit ac0b3c9 into dev May 17, 2024
34 checks passed
@FelixKrueger FelixKrueger deleted the fix/tech-reps branch May 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FelixKrueger FelixKrueger FelixKrueger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @maxulysse @FelixKrueger