Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/samplename join #381

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix/samplename join #381

merged 2 commits into from
Feb 23, 2024

Conversation

sateeshperi
Copy link
Contributor

should fix #378

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sateeshperi sateeshperi requested a review from a team as a code owner February 22, 2024 04:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 457f9d6

+| ✅ 167 tests passed       |+
#| ❔   5 tests were ignored |#
-| ❌   8 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/WorkflowMethylseq.groovy
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - pyproject.toml does not match the template

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-22 04:04:51

@edmundmiller edmundmiller added this to the 2.7.0 milestone Feb 23, 2024
edmundmiller
edmundmiller approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and merge this before #380 because that's going to be more of a mess than one red ❌.

@edmundmiller edmundmiller merged commit 1faa12b into dev Feb 23, 2024
31 of 32 checks passed
@edmundmiller edmundmiller deleted the fix/samplename-join branch February 23, 2024 17:43
This was referenced Feb 28, 2024
Merged
Open
@CathyXD CathyXD mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger FelixKrueger is a code owner automatically assigned from nf-core/methylseq

Assignees

@sateeshperi sateeshperi

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sateeshperi @edmundmiller