-
Notifications
You must be signed in to change notification settings - Fork 83
DSL2 - CLASSIFY_MTDNA_HAPLOGROUP #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51866a3
to
ab7ebd5
Compare
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.0. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
596e6d0
to
148ab55
Compare
// https://github.com/nf-core/modules/tree/master/subworkflows | ||
// You can also ask for help via your pull request or on the #subworkflows channel on the nf-core Slack workspace: | ||
// https://nf-co.re/join | ||
// TODO nf-core: A subworkflow SHOULD import at least two modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true here? We don't really need more than one in this case, but it seems logical to have this as a subworkflow.
(The Y-DNA stuff will definitely offer making a reference genome that can be used by Yleaf as part of a subworkflow.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing one one module is fine 👍
I agree that a SWF makes more sense.
|
||
if (params.run_mtdna_haplogroup) { | ||
if (!params.run_genotyping) { | ||
error "Cannot run mtDNA haplogroup classification (--run_mtdna_haplogroup) without running genotyping (--run_genotyping). VCF files are required as input." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there used to be a vcf2genome in eager2 that output a consensus fasta. Is that still a thing? Because haplogrep3 also works with mtDNA sequences aligned to rCRS or RSRS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. vcf2genome is discontinued and will not be supported in eager 3.* .
Consensus sequence calling will be added soon™ ( #1142 ).
61b74a2
to
a217ca2
Compare
manual_tests.md
a217ca2
to
7cba844
Compare
…roblem with collection/name not working
Whoops rebase disaster... See #1148 for proper commits |
Work in progress - adding mtDNA haplogroup classification
Haplogrep3 integration
--tree
needs to be passed in fromhaplogrep3_tree_id
[... 1h50m passes]
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).