Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging changes from master into dev to 1.5.4 fix release merging issues #298

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Merging changes from master into dev to 1.5.4 fix release merging issues #298

merged 3 commits into from
Dec 4, 2024
+0 −0

Conversation

nschcolnicov
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nschcolnicov nschcolnicov requested a review from a team as a code owner December 4, 2024 21:41
@nschcolnicov nschcolnicov requested review from kobelavaerts and removed request for a team December 4, 2024 21:41
@nschcolnicov nschcolnicov changed the base branch from master to dev December 4, 2024 21:42
@nf-core nf-core deleted a comment from github-actions bot Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2702748

+| ✅ 206 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-04 21:42:33

@nschcolnicov nschcolnicov requested a review from apeltzer December 4, 2024 22:05
@nf-core nf-core deleted a comment from github-actions bot Dec 4, 2024
@nschcolnicov
Copy link
Contributor Author

@apeltzer We need to fix the commit history before we can release 1.5.4

@nschcolnicov nschcolnicov merged commit 9ea845e into dev Dec 4, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@kobelavaerts kobelavaerts Awaiting requested review from kobelavaerts kobelavaerts was automatically assigned from nf-core/demultiplex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschcolnicov @apeltzer