Important! Template update for nf-core/tools v3.0.2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
approved these changes
Oct 11, 2024
maxulysse
reviewed
Oct 11, 2024
LouisLeNezet
approved these changes
Oct 11, 2024
| @@ -41,17 +41,32 @@ jobs: | |||
| python-version: "3.12" | |||
| architecture: "x64" | |||
|
|
|||
| - name: read .nf-core.yml | |||
| uses: pietrobolcato/[email protected] | |||
There was a problem hiding this comment.
I don't know why we use pietrobolcato here and nichmor in the other workflow.
There was a problem hiding this comment.
That's a good question, let's invoke @mirpedrol
There was a problem hiding this comment.
We found a bug with pietrobolcato action in the other workflow, so we had to use a fix, but we don't find the same bug here so we can use the original one
| repository_type: pipeline | ||
| template: | ||
| author: "@maxulysse" | ||
| description: Generate Panel of Normals, models or other similar references from |
There was a problem hiding this comment.
Shouldn't it be ?
Suggested change
| description: Generate Panel of Normals, models or other similar references from | |
| description: Generate panel of normals, models or other similar references from |
There was a problem hiding this comment.
I'd rather keep Panels of Normals (aka PONs), with these uppercase letters, as it's a generally common in such settings
Co-authored-by: Louis LE NEZET <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
3.0.2of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-3.0.2branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.
For more information about this release of nf-core/tools, please see the
v3.0.2release page.