Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params.save_merged to properly save merged files #163

Merged
merged 4 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Fixed`

- [#163](https://github.com/nf-core/bacass/pull/163) Fixed `params.save_merged` to properly save merged files
Daniel-VM marked this conversation as resolved.
Show resolved Hide resolved
- [#160](https://github.com/nf-core/bacass/pull/160) Fixed memory issues in KmerFinder, fixed handling of no species detected, and fixed handling of empty fasta files in the prokka/bakkta channel.
- [#157](https://github.com/nf-core/bacass/pull/157) Fixed corrupted zenodo URL of Kmerfinder database.
- [#154](https://github.com/nf-core/bacass/pull/154) Fixed kmerfinder script and increase resources to prevent memory issues.
Expand Down
6 changes: 6 additions & 0 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ if (!params.skip_fastp) {
mode: params.publish_dir_mode,
pattern: "*.fail.fastq.gz",
enabled: params.save_trimmed_fail
],
[
path: { "${params.outdir}/trimming/shortreads" },
mode: params.publish_dir_mode,
pattern: "*.merged.fastq.gz",
enabled: params.save_merged
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
"save_merged": {
"type": "boolean",
"description": "save all merged reads to the a file ending in `*.merged.fastq.gz`"
"description": "save all merged reads to the a file ending in `*.merged.fastq.gz`. This option enables read merging and saves all merged reads to a file ending in `*.merged.fastq.gz`; these reads will be won't be passed to the assembly process."
},
"skip_fastqc": {
"type": "boolean",
Expand Down
Loading