Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory issues, handle KmerFinder results, and manage empty fasta files #160

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

This PR includes the following changes:

  • Fix memory issues due to config in KmerFinder: Addressed memory problems related to KmerFinder configuration.
  • Handle KmerFinder results when no species hit is detected: Improved handling when KmerFinder detects no species.
  • Handle prokka/bakkta channel when fasta file is empty: Updated handling for empty fasta files in the prokka/bakkta channel.

Copy link

github-actions bot commented Sep 3, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit fcf0ab9

+| ✅ 198 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-03 11:48:18

@Daniel-VM Daniel-VM marked this pull request as ready for review September 3, 2024 11:48
@Daniel-VM Daniel-VM merged commit c66630f into nf-core:dev Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants