Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewer 2 suggestions before v2.3.0 release #139

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Reviewer 2 suggestions before v2.3.0 release #139

merged 2 commits into from
Jun 3, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

PR has reviewer nº2 suggestions before v2.3.0 release (#137 )

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cb1c258

+| ✅ 195 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-03 06:41:26

@Daniel-VM Daniel-VM mentioned this pull request May 30, 2024
Merged
10 tasks
@Daniel-VM Daniel-VM marked this pull request as ready for review May 30, 2024 09:33
@Daniel-VM Daniel-VM requested a review from d4straub May 31, 2024 14:05
d4straub
d4straub approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay, had a bank holiday here :)

bin/multiqc_to_custom_csv.py Outdated Show resolved Hide resolved
@Daniel-VM
Copy link
Contributor Author

No worries, hope you have rested :).

@Daniel-VM Daniel-VM merged commit 6d91eb5 into nf-core:dev Jun 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-VM @d4straub