Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version 2.7.1 to 2.8.0dev #661

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Bump version 2.7.1 to 2.8.0dev #661

merged 3 commits into from
Nov 14, 2023

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Nov 13, 2023 •
edited
Loading

After release PR to bump version and update CHANGELOG.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2992fb7

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-13 11:43:24

@d4straub
Copy link
Collaborator Author

It's surprising to me that the pplace test doesnt work. I'll need to test it locally, tomorrow.

@jannikseidelQBiC
Copy link

Seems there is a file missing (output/phyloseq/qiime2_phyloseq.rds) for the test of pplace. I try to figure out why it is not generate by the workflow (if you are not faster than me).

@d4straub
Copy link
Collaborator Author

Test passes now, probably was a hickup with github.

jannikseidelQBiC
jannikseidelQBiC approved these changes Nov 14, 2023
View reviewed changes
Copy link

@jannikseidelQBiC jannikseidelQBiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d4straub
Copy link
Collaborator Author

Thanks!

@d4straub d4straub merged commit 1067c7c into nf-core:dev Nov 14, 2023
17 checks passed
@d4straub d4straub deleted the bump-version-2.7.1-to-2.8.0dev branch November 14, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannikseidelQBiC jannikseidelQBiC jannikseidelQBiC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4straub @jannikseidelQBiC