Correct reference to character limit #1524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutdenolf
approved these changes
Dec 19, 2024
| @@ -93,7 +93,7 @@ described by the following :index:`rules <rules; naming>`: | |||
| ^[a-zA-Z0-9_]([a-zA-Z0-9_.]*[a-zA-Z0-9_])?$ | |||
|
|
|||
| The length should be limited to no more than | |||
| 63 characters (imposed by the HDF5 :index:`rules <rules; HDF5>` for names). | |||
| 63 characters (imposed by the HDF4 :index:`rules <rules; HDF>` for names). | |||
There was a problem hiding this comment.
I found this
The max size of an SD dataset name in HDF4 (from HDF4 documentation) is 64.
But in in the wild we have encountered longer names. As long as the HDF4 name is not greater than NC_MAX_NAME, our code will be OK.
I could not find it in the HDF4 specs: https://doi.org/10.5281/zenodo.13310722
There was a problem hiding this comment.
Thanks, there's no such limit in HDF5.
There was a problem hiding this comment.
HDF4 library truncates to VSNAMELENMAX (a preprocessor symbol that is 64 by default) for in-memory names. See hlimits.h#L55-L64
|
Didn't we drop support for HDF4? If so, no need to reference it now.
…On Thu, Dec 19, 2024, 9:38 AM Peter Chang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In manual/source/datarules.rst
<#1524 (comment)>
:
> @@ -93,7 +93,7 @@ described by the following :index:`rules <rules; naming>`:
^[a-zA-Z0-9_]([a-zA-Z0-9_.]*[a-zA-Z0-9_])?$
The length should be limited to no more than
- 63 characters (imposed by the HDF5 :index:`rules <rules; HDF5>` for names).
+ 63 characters (imposed by the HDF4 :index:`rules <rules; HDF>` for names).
HDF4 library truncates to VSNAMELENMAX (a preprocessor symbol that is 64
by default) for in-memory names. See hlimits.h#L55-L64
<https://github.com/HDFGroup/hdf4/blob/ae94aece1220dfa2393be65d0f44fd3234307625/hdf/src/hlimits.h#L55-L64>
—
Reply to this email directly, view it on GitHub
<#1524 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMAUXC7U65DOF4ORJA32GLSALAVCNFSM6AAAAABT4OMT7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJVGI3TMNBVHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
tacaswell
approved these changes
Dec 23, 2024
tacaswell
reviewed
Dec 23, 2024
| @@ -93,7 +93,7 @@ described by the following :index:`rules <rules; naming>`: | |||
| ^[a-zA-Z0-9_]([a-zA-Z0-9_.]*[a-zA-Z0-9_])?$ | |||
|
|
|||
| The length should be limited to no more than | |||
| 63 characters (imposed by the HDF5 :index:`rules <rules; HDF5>` for names). | |||
| 63 characters (imposed by the HDF4 :index:`rules <rules; HDF>` for names). | |||
There was a problem hiding this comment.
Suggested change
| 63 characters (imposed by the HDF4 :index:`rules <rules; HDF>` for names). | |
| 63 characters (historically imposed by the HDF4 :index:`rules <rules; HDF>` for names). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.