Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ncov-ingest geolocation rules #17

Open
17 tasks
joverlee521 opened this issue Feb 7, 2025 · 2 comments
Open
17 tasks

Remove use of ncov-ingest geolocation rules #17

joverlee521 opened this issue Feb 7, 2025 · 2 comments
Assignees

Comments

@joverlee521
Copy link

joverlee521 commented Feb 7, 2025

Once augur curate apply-geolocation-rules uses built-in default rules (nextstrain/augur#1744 + nextstrain/augur#1745), we can remove the use of ncov-ingest geolocation rules from pathogen ingest workflows.

TODOs

Based on GitHub search

We can prioritize updating the pathogen-repo-guide, docs, zika, and mpox

Other pathogens can be updated later as needed

  • avian-flu
  • dengue
  • hmpv
  • lassa
  • measles
  • nipah
  • norovirus
  • oropouche
  • rabies
  • rsv
  • rubella
  • WNV
  • yellow-fever
@jameshadfield
Copy link
Member

Other pathogens can be updated later as needed

Once the new version of Augur is out, will these at least need to use --no-default-rules, or will they be OK because their custom rules will essentially include the default rules as they fetch (a similar version of) the defaults and use them as custom rules?

@joverlee521
Copy link
Author

Other pathogens can be updated later as needed

Once the new version of Augur is out, will these at least need to use --no-default-rules, or will they be OK because their custom rules will essentially include the default rules as they fetch (a similar version of) the defaults and use them as custom rules?

They should be okay because their custom rules still include the ncov-ingest rules that will override the default Augur rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants