Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize error handling and console output functions #1717

Open
5 tasks
victorlin opened this issue Jan 13, 2025 · 0 comments
Open
5 tasks

Standardize error handling and console output functions #1717

victorlin opened this issue Jan 13, 2025 · 0 comments

Comments

@victorlin
Copy link
Member

victorlin commented Jan 13, 2025

Several parts of the code were written prior to the availability of top-level exception handling and shared console output functions. These should be updated.

Tasks

  • Replace usage of file=sys.stderr + sys.exit (example) with raise AugurError
  • Replace AlignmentError with AugurError (unmerged example)
  • Make ConflictingArgumentsException extend AugurError (unmerged example)
  • Use the same exit code (both 1 and 2 are used)
  • Replace usage of print(file=sys.stderr) with print_err
    • Maybe this should be called print_info instead since the message is informational, only the file stream is stderr
    • Maybe create a new function print_warn to standardize prefixing of messages with WARNING:

Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant