Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pathogen-repo-build should save AWS_DEFAULT_REGION envvar #97

Closed
joverlee521 opened this issue Jun 12, 2024 · 1 comment · Fixed by #101
Closed

pathogen-repo-build should save AWS_DEFAULT_REGION envvar #97

joverlee521 opened this issue Jun 12, 2024 · 1 comment · Fixed by #101
Assignees
@joverlee521

Comments

@joverlee521
Copy link
Contributor

As part of the step for saving the AWS credentials for the build runtime, the workflow should also save the AWS_DEFAULT_REGION envvar.

https://github.com/nextstrain/.github/blob/master/.github/workflows/pathogen-repo-build.yaml#L285-L290

This should help alleviate the pain for nextstrain/docker-base#216.
@joverlee521
Copy link
Contributor Author

I suspect the lack of AWS_DEFAULT_REGION actually breaks builds that use aws in the conda runtime because conda-base already uses AWS CLI v2, but I haven't tested.

@joverlee521 joverlee521 mentioned this issue Jun 18, 2024
Merged
1 task
@joverlee521 joverlee521 self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joverlee521 joverlee521

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pathogen-repo-build improvements nextstrain/.github
1 participant
@joverlee521