-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve multi stop plan unit generation #39
Open
dirkschumacher
wants to merge
7
commits into
develop
Choose a base branch
from
ds/chore/fast-generator
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkschumacher
force-pushed
the
ds/chore/fast-generator
branch
from
May 10, 2024 14:41
eb7497f
to
c21c0cf
Compare
dirkschumacher
requested review from
larsbeck,
merschformann,
nilsbeck,
sebastian-quintero and
davidrijsman
May 10, 2024 14:54
sebastian-quintero
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which state is this? 🤔
@merschformann I want to do some further benchmarking. I'll ping you all again once that is done |
dirkschumacher
force-pushed
the
ds/chore/fast-generator
branch
from
May 13, 2024 11:45
1466b49
to
fcbc3d3
Compare
🤔 linter |
Waiting on #47 to fix some benchmark tests |
dirkschumacher
force-pushed
the
ds/chore/fast-generator
branch
from
May 16, 2024 22:11
fcbc3d3
to
78decc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explored a bit to reduce some overhead when generating sequences for move generation. In addition this has the effect that we don't spawn go routines so deep in the search.
Below are two smaller benchmark tests. The full set I cannot yet run until #47 is fixed, but this already captures some of the benefits here as it's mostly about allocations.