Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello-config module #371

Merged
merged 17 commits into from
Sep 23, 2024
Merged

Add hello-config module #371

merged 17 commits into from
Sep 23, 2024

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Sep 19, 2024

  • First draft of hello-config a module for setting Nextflow configuration

Covers setting up configuration of a Nextflow pipeline including software packaging (conda, docker), process directives (cpus, memory), execution (local, slurm) and profiles.

Resolves #370

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit d996110
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/66f1686b37ddfc00084050d6
😎 Deploy Preview https://deploy-preview-371--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +54 to +55
docker.enabled = false
conda.enabled = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't really need to disable docker to run conda

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be nice to be explicit? but I agree about in the profiles.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do it, then explain why you do it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 6d1a839

profiles {
'docker' {
docker.enabled = true
conda.enabled = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the enabled = false are overkill.
We have that in nf-core, but we might be doing too much

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified it to not include those bits!

Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the flow on this module. Great addition!

docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved
docs/hello_nextflow/06_hello_config.md Outdated Show resolved Hide resolved

### 4.3 Seqera Platform

Setting up and configuring Nextflow for different executors can be complex and time-consuming. Seqera Platform simplifies this process by providing a user-friendly interface to manage and run Nextflow pipelines on various compute platforms. With Seqera Platform, you can easily configure and launch your pipelines on local machines, HPC clusters, cloud environments, and Kubernetes clusters. The platform abstracts the underlying infrastructure, allowing you to focus on your analysis and research without worrying about the technical details of setting up and managing the execution environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Setting up and configuring Nextflow for different executors can be complex and time-consuming. Seqera Platform simplifies this process by providing a user-friendly interface to manage and run Nextflow pipelines on various compute platforms. With Seqera Platform, you can easily configure and launch your pipelines on local machines, HPC clusters, cloud environments, and Kubernetes clusters. The platform abstracts the underlying infrastructure, allowing you to focus on your analysis and research without worrying about the technical details of setting up and managing the execution environment.
Setting up and configuring Nextflow for different executors can be complex and time-consuming.
Seqera Platform simplifies this process by providing a user-friendly interface for managing and running Nextflow pipelines on various compute platforms.
With Seqera Platform, you can easily configure and launch your pipelines on local machines, HPC clusters, cloud environments, and Kubernetes clusters.
The platform abstracts the underlying infrastructure, allowing you to focus on your analysis and research without worrying about the technical details of setting up and managing the execution environment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the Seqera Platform bit so this is no longer relevant.

@vdauwera
Copy link
Collaborator

Looks great overall, some thoughts for future improvements TBC but this seems great as a first pass to try on a cohort of learners

@adamrtalbot adamrtalbot merged commit b7baaba into master Sep 23, 2024
8 checks passed
@adamrtalbot adamrtalbot deleted the hello-config-draft-1 branch September 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module proposal: hello-config
4 participants