Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Revert ImmutableMap #68

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Revert ImmutableMap #68

merged 3 commits into from
Jul 10, 2023

Conversation

mirpedrol
Copy link
Collaborator

@mirpedrol mirpedrol commented Jul 6, 2023

Implemented the new class ImmutableMap for meta maps introduced a bug when reumming pipelies.
Revert the changes added before and return a normal Map.
Reason: nextflow-io#23
Close #47

@mirpedrol mirpedrol requested a review from nvnieuwk July 6, 2023 11:20
Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sad that it has to go now :/

@mirpedrol
Copy link
Collaborator Author

Thanks for the review @nvnieuwk! I hope we can add it back, or a similar solution, soon!

@mirpedrol mirpedrol merged commit b4c5810 into nextflow-io:master Jul 10, 2023
3 checks passed
@mirpedrol mirpedrol deleted the revert-immutablemap branch July 10, 2023 08:33
@nvnieuwk
Copy link
Collaborator

I hope so too 🙏

@robsyme
Copy link
Collaborator

robsyme commented Jul 10, 2023

We can bring this back once this Nextflow PR gets in: nextflow-io/nextflow#4077

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImmutableMap clashes with the -resume flag
3 participants