Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Allow quoted fields for csv files in .fromSamplesheet() #63

Merged

Conversation

koenbossers
Copy link

fixes #62

@koenbossers
Copy link
Author

koenbossers commented Jun 29, 2023

I do not know how to write tests for this feature (or actually in Groovy at all 😄 ), so it is probably necessary to add a specific test to the current test suite

@koenbossers
Copy link
Author

Ready for review!

Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@koenbossers
Copy link
Author

Thanks! I am not allowed to merge, so feel free to do so

@nvnieuwk nvnieuwk merged commit 182c19a into nextflow-io:master Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow quotes strings containing commas in .fromSamplesheet() for .csv files
2 participants