-
Notifications
You must be signed in to change notification settings - Fork 1
build: Use nextflow gradle plugin #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: Use nextflow gradle plugin #26
Conversation
Signed-off-by: Edmund Miller <[email protected]>
57e06ee
to
eacccc7
Compare
sourceSets { | ||
main { | ||
groovy { | ||
srcDirs = ['src/main/groovy'] | ||
} | ||
resources { | ||
srcDirs = ['src/main/resources'] | ||
} | ||
} | ||
test { | ||
groovy { | ||
srcDirs = ['src/test/groovy'] | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed
// Replace commons-logging with jcl-over-slf4j | ||
implementation 'org.slf4j:jcl-over-slf4j:2.0.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed
testImplementation ("org.apache.groovy:groovy-test:4.0.23") { exclude group: 'org.apache.groovy' } | ||
testImplementation ("cglib:cglib-nodep:3.3.0") | ||
testImplementation ("org.objenesis:objenesis:3.1") | ||
testImplementation ("org.spockframework:spock-core:2.3-groovy-4.0") { exclude group: 'org.apache.groovy'; exclude group: 'net.bytebuddy' } | ||
testImplementation ('org.spockframework:spock-junit4:2.3-groovy-4.0') { exclude group: 'org.apache.groovy'; exclude group: 'net.bytebuddy' } | ||
testImplementation ('com.google.jimfs:jimfs:1.1') | ||
|
||
testImplementation(testFixtures("io.nextflow:nextflow:$nextflowVersion")) | ||
testImplementation(testFixtures("io.nextflow:nf-commons:$nextflowVersion")) | ||
// Add back Nextflow test dependencies | ||
testImplementation "io.nextflow:nextflow:${nextflowPlugin.nextflowVersion}" | ||
testImplementation(testFixtures("io.nextflow:nextflow:${nextflowPlugin.nextflowVersion}")) | ||
testImplementation(testFixtures("io.nextflow:nf-commons:${nextflowPlugin.nextflowVersion}")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of this can be removed
configurations { | ||
// see https://docs.gradle.org/4.1/userguide/dependency_management.html#sub:exclude_transitive_dependencies | ||
runtimeClasspath.exclude group: 'org.slf4j', module: 'slf4j-api' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed
// AWS Athena dependencies setup - migrated from the original build.gradle | ||
apply plugin: 'de.undercouch.download' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be moved to the plugins
block at the top
// For the Nextflow plugin Gradle plugin | ||
pluginManagement { | ||
repositories { | ||
mavenLocal() | ||
gradlePluginPortal() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed anymore since the nextflow gradle plugin was published to Maven Central
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this on hold, until we don't have a pre-production plugin and registry
No description provided.