build: Use nextflow gradle plugin #26
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edmund Miller <[email protected]>
edmundmiller
force-pushed
the
nextflow-plugin-gradle
branch
from
57e06ee to
eacccc7
Compare
bentsherman
reviewed
Apr 10, 2025
Comment on lines
+31
to
45
| sourceSets { | ||
| main { | ||
| groovy { | ||
| srcDirs = ['src/main/groovy'] | ||
| } | ||
| resources { | ||
| srcDirs = ['src/main/resources'] | ||
| } | ||
| } | ||
| test { | ||
| groovy { | ||
| srcDirs = ['src/test/groovy'] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this can be removed
bentsherman
reviewed
Apr 10, 2025
Comment on lines
+64
to
+65
| // Replace commons-logging with jcl-over-slf4j | ||
| implementation 'org.slf4j:jcl-over-slf4j:2.0.7' |
There was a problem hiding this comment.
I think this can be removed
bentsherman
reviewed
Apr 10, 2025
Comment on lines
74
to
+84
| testImplementation ("org.apache.groovy:groovy-test:4.0.23") { exclude group: 'org.apache.groovy' } | ||
| testImplementation ("cglib:cglib-nodep:3.3.0") | ||
| testImplementation ("org.objenesis:objenesis:3.1") | ||
| testImplementation ("org.spockframework:spock-core:2.3-groovy-4.0") { exclude group: 'org.apache.groovy'; exclude group: 'net.bytebuddy' } | ||
| testImplementation ('org.spockframework:spock-junit4:2.3-groovy-4.0') { exclude group: 'org.apache.groovy'; exclude group: 'net.bytebuddy' } | ||
| testImplementation ('com.google.jimfs:jimfs:1.1') | ||
|
|
||
| testImplementation(testFixtures("io.nextflow:nextflow:$nextflowVersion")) | ||
| testImplementation(testFixtures("io.nextflow:nf-commons:$nextflowVersion")) | ||
| // Add back Nextflow test dependencies | ||
| testImplementation "io.nextflow:nextflow:${nextflowPlugin.nextflowVersion}" | ||
| testImplementation(testFixtures("io.nextflow:nextflow:${nextflowPlugin.nextflowVersion}")) | ||
| testImplementation(testFixtures("io.nextflow:nf-commons:${nextflowPlugin.nextflowVersion}")) |
There was a problem hiding this comment.
I think all of this can be removed
bentsherman
reviewed
Apr 10, 2025
Comment on lines
+87
to
+90
| configurations { | ||
| // see https://docs.gradle.org/4.1/userguide/dependency_management.html#sub:exclude_transitive_dependencies | ||
| runtimeClasspath.exclude group: 'org.slf4j', module: 'slf4j-api' | ||
| } |
There was a problem hiding this comment.
I think this can be removed
bentsherman
reviewed
Apr 10, 2025
Comment on lines
+131
to
+132
| // AWS Athena dependencies setup - migrated from the original build.gradle | ||
| apply plugin: 'de.undercouch.download' |
There was a problem hiding this comment.
This can be moved to the plugins block at the top
bentsherman
reviewed
Apr 10, 2025
Comment on lines
+1
to
+7
| // For the Nextflow plugin Gradle plugin | ||
| pluginManagement { | ||
| repositories { | ||
| mavenLocal() | ||
| gradlePluginPortal() | ||
| } | ||
| } |
There was a problem hiding this comment.
This should not be needed anymore since the nextflow gradle plugin was published to Maven Central
pditommaso
reviewed
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.