Update docs with latest changes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awgymer
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Was it previously null because this was not fully implemented? Trying to understand this change better.
There was a problem hiding this comment.
No this was a small oversight of mine. I didn't understand the JSON schema load function very well when I wrote that and made a wrong assumption. Now it does what I wanted it to do all along :p
|
@mirpedrol, @ewels and @mashehu can one of you take a look at this PR if you have some time? I'd love to get this released since the update contains some changes that will be needed for nf-core linting to pass: nf-core/tools#3116 |
mirpedrol
approved these changes
Aug 20, 2024
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]>
Co-authored-by: Júlia Mir Pedrol <[email protected]>
|
Merging this! We can still make changes when other issues have been detected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs to show the changes done in #39