Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce secret size to 160 bits #1483

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 8, 2024

Ref #1324 (comment)

We currently have a length of 160 * 5 bit = 800 bit which is a bit excessive.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny requested a review from ChristophWurst February 8, 2024 20:17
@st3iny st3iny self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4b530a) 44.29% compared to head (7eb6dc4) 44.29%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1483   +/-   ##
=========================================
  Coverage     44.29%   44.29%           
  Complexity       99       99           
=========================================
  Files            19       19           
  Lines           298      298           
=========================================
  Hits            132      132           
  Misses          166      166           
Flag Coverage Δ
unittests 44.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst merged commit f7d34d9 into master Feb 8, 2024
17 checks passed
@ChristophWurst ChristophWurst deleted the fix/reduce-totp-secret-to-160-bits branch February 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants