Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] fix: replace deprecated translation methods #6895

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 10, 2025

Backport of PR #6567

@backportbot backportbot bot requested a review from luka-nextcloud February 10, 2025 12:18
@backportbot backportbot bot added bug Something isn't working 3. to review labels Feb 10, 2025
@backportbot backportbot bot added this to the Nextcloud 31 milestone Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (1685654) to head (69263f5).
Report is 2 commits behind head on stable31.

Files with missing lines Patch % Lines
src/components/Modal/Translate.vue 0.00% 36 Missing ⚠️
src/components/Assistant.vue 0.00% 1 Missing ⚠️
src/components/Menu/MenuBar.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable31    #6895      +/-   ##
============================================
+ Coverage     46.59%   46.60%   +0.01%     
============================================
  Files           750      740      -10     
  Lines         34590    34581       -9     
  Branches       1269     1259      -10     
============================================
  Hits          16118    16118              
- Misses        17850    17851       +1     
+ Partials        622      612      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Altahrim Altahrim mentioned this pull request Feb 12, 2025
4 tasks
@AndyScherzinger AndyScherzinger merged commit 63ca8d9 into stable31 Feb 12, 2025
66 of 68 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/6567/stable31 branch February 12, 2025 20:49
@juliusknorr
Copy link
Member

Original PR is not merged yet and had some issues reported, let me revert that for now. We mostly had that PR for easier testing as far as I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants