Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set room to read when last message is an update message #2006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SystemKeeper
Copy link
Collaborator

We set the room to read, when we enter the room or receive new messages. Currently we enforce that the last message needs to be a non-update message, so when the last message is a reaction or edit, we will not update the room. This PR changes the logic a bit, so that we

  1. Always set the room to read and only update the last message in case there's one
  2. Check if we can find a non-update message, instead of relying on the last message

It's still a bit problematic if the server is very slow and we receive "old" data, but it should improve things.

@SystemKeeper SystemKeeper requested a review from Ivansss March 2, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant