Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply theming to user mentions #4774

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

apply theming to user mentions #4774

wants to merge 7 commits into from

Conversation

sowjanyakch
Copy link
Contributor

see comment #4672 (comment)

user_mentions

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch marked this pull request as ready for review February 28, 2025 12:01
@sowjanyakch sowjanyakch self-assigned this Feb 28, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 28, 2025
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4774-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch changed the title theme user mentions apply theming to user mentions Feb 28, 2025
@@ -670,6 +674,10 @@ class ChatActivity :
}
}

conversationUser?.let { user ->
chatViewModel.fetchUserData(user)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only be done every now and then.
I think @Ivansss suggested on App-Start or something around 24h?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants