Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team mentions #4678

Merged
merged 12 commits into from
Feb 7, 2025
Merged

Team mentions #4678

merged 12 commits into from
Feb 7, 2025

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Feb 4, 2025

Resolve #4672

  • Show proper system messages when adding/ removing a team.
  • Implement team mention support.
  • General placeholder support for mentions (will implement this in a different PR).

๐Ÿ–ผ๏ธ Screenshots

Before After
team_mentions_bug team_mentions

๐Ÿšง TODO

  • ...

๐Ÿ Checklist

  • โ›‘๏ธ Tests (unit and/or integration) are included or not needed
  • ๐Ÿ”– Capability is checked or not needed
  • ๐Ÿ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • ๐Ÿ“… Milestone is set
  • ๐ŸŒธ PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Team support Team mentions Feb 4, 2025
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch marked this pull request as ready for review February 7, 2025 08:36
@sowjanyakch sowjanyakch self-assigned this Feb 7, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 7, 2025
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi enabled auto-merge February 7, 2025 11:35
@mahibi mahibi added this to the 21.1.0 milestone Feb 7, 2025
@mahibi
Copy link
Collaborator

mahibi commented Feb 7, 2025

/backport to stable-21.0

Copy link
Contributor

github-actions bot commented Feb 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4678-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@mahibi mahibi merged commit 798c024 into master Feb 7, 2025
18 checks passed
@mahibi mahibi deleted the team_support branch February 7, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circles / Teams support
3 participants