feat: Add event to highlight active menu #51207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
Koc
force-pushed
the
feature/highlight-active-menu
branch
from
cbe5811 to
15a1b00
Compare
nickvergessen
requested review from
a team,
nfebe and
szaimen
and removed request for
a team
Koc
commented
Mar 3, 2025
| @@ -88,10 +88,12 @@ export default defineComponent({ | |||
|
|
|||
| mounted() { | |||
| subscribe('nextcloud:app-menu.refresh', this.setApps) | |||
| subscribe('nextcloud:app-menu.active', this.setActive) | |||
There was a problem hiding this comment.
IMHO method in OC namespace is better. This allow us to write more universal apps to support multiple NC versions:
if (OC.setNavigationActive) {
// we are on newer NC api and can use method
} else {
// we are on legacy NC api and should do css manipulations to preserve BC
}
There was a problem hiding this comment.
OC. shall not be used by apps, its private API and might change at any time.
Also OCP. is deprecated as we aim to remove all exposed global states and only provide version agnostic API through packages.
I do not get the use case here as it is not possible to switch apps without reloading the page? |
susnux
reviewed
Mar 3, 2025
| @@ -88,10 +88,12 @@ export default defineComponent({ | |||
|
|
|||
| mounted() { | |||
| subscribe('nextcloud:app-menu.refresh', this.setApps) | |||
| subscribe('nextcloud:app-menu.active', this.setActive) | |||
There was a problem hiding this comment.
Suggested change
| subscribe('nextcloud:app-menu.active', this.setActive) | |
| subscribe('nextcloud:app-menu:activate', this.setActive) |
https://github.com/nextcloud-libraries/nextcloud-event-bus?tab=readme-ov-file#naming-convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nextcloud/tables#1477 (comment)
Summary
Right now some modules uses css manipulations to mark some items as active. Would be nice to have proper API for that.
TODO
OCmethodChecklist