add appconfig to disable fixed userfolder permissions optimization #51145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
skjnldsv and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
home-folder-readonly
branch
2 times, most recently
from
02aa7cf to
0b62c0e
Compare
…imization Signed-off-by: Robin Appelman <[email protected]>
… at / exists Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
home-folder-readonly
branch
from
0b62c0e to
1b40100
Compare
artonge
reviewed
Mar 3, 2025
| /** | ||
| * Check if any mountpoint is configured that overwrite the home folder | ||
| * | ||
| * @return bool |
| @@ -86,6 +87,10 @@ abstract class StoragesServiceTest extends \Test\TestCase { | |||
| * @var \PHPUnit\Framework\MockObject\MockObject|IEventDispatcher | |||
| */ | |||
| protected IEventDispatcher $eventDispatcher; | |||
| /** | |||
| * @var \PHPUnit\Framework\MockObject\MockObject|IAppConfig | |||
There was a problem hiding this comment.
Suggested change
| * @var \PHPUnit\Framework\MockObject\MockObject|IAppConfig | |
| * @var \PHPUnit\Framework\MockObject\MockObject&IAppConfig |
| @@ -46,6 +47,8 @@ abstract class NodeTest extends \Test\TestCase { | |||
| protected $eventDispatcher; | |||
| /** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */ | |||
| protected $cacheFactory; | |||
| /** @var IAppConfig|\PHPUnit\Framework\MockObject\MockObject */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var IAppConfig|\PHPUnit\Framework\MockObject\MockObject */ | |
| /** @var IAppConfig&\PHPUnit\Framework\MockObject\MockObject */ |
| @@ -39,6 +40,8 @@ class RootTest extends \Test\TestCase { | |||
| private $eventDispatcher; | |||
| /** @var ICacheFactory|\PHPUnit\Framework\MockObject\MockObject */ | |||
| protected $cacheFactory; | |||
| /** @var IAppConfig|\PHPUnit\Framework\MockObject\MockObject */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var IAppConfig|\PHPUnit\Framework\MockObject\MockObject */ | |
| /** @var IAppConfig&\PHPUnit\Framework\MockObject\MockObject */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to save having to fetch the metadata of the home folder in many cases, we always assume the same value for the permissions of the home folder.
This does however break if the admin has configured an external storage mounted at
/with different permissions.To fix those cases without breaking the optimization for other instances, this adds a flag in the appconfig to disable the optimization and actually fetch the correct permissions.
This flag is automatically set by the files_external app when such an external storage is detected
To test:
/and set as readonly