Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(imip): dont propagate attendee changes in reply message #51131

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(imip): dont propagate attendee changes in reply message #51131

wants to merge 1 commit into from
+56 −2

Conversation

hamza221
Copy link
Contributor

Summary

TODO

  • ...

Checklist

@hamza221 hamza221 added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Feb 28, 2025
@hamza221 hamza221 self-assigned this Feb 28, 2025
SebastianKrupinski
SebastianKrupinski reviewed Feb 28, 2025
View reviewed changes
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
@@ -185,7 +185,8 @@ public function schedule(Message $iTipMessage) {
switch (strtolower($iTipMessage->method)) {
case self::METHOD_REPLY:
$method = self::METHOD_REPLY;
$data = $this->imipService->buildBodyData($vEvent, $oldVevent);
$organizerEvent = $this->imipService->getOrganizerVEvent($vEvent->uid, $iTipMessage->recipient);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you can't just pull the event by the recipient, This will fail, for external organizers

@susnux susnux added this to the Nextcloud 32 milestone Mar 2, 2025
@hamza221
Copy link
Contributor Author

hamza221 commented Mar 3, 2025

@SebastianKrupinski would it make sense to keep this even that it only works if the organiser is a local user?
I mean check if he is and search for the event. Sent potentially wrong message in the other case? Would be better than nothing no ?

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski would it make sense to keep this even that it only works if the organiser is a local user? I mean check if he is and search for the event. Sent potentially wrong message in the other case? Would be better than nothing no ?

I don't think having different code paths for internal and external attendees is a good idea, just makes it too complex, the only thing I would keep is the separate method for the reply message, as the reply does not need event comparison, and all the extra information that is normally generate

@hamza221 hamza221 marked this pull request as draft March 3, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski left review comments

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: dav
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

Changes by attendee propagating to organiser
3 participants
@hamza221 @SebastianKrupinski @susnux