-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group #51000
Conversation
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
bd81ef7
to
9714d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the nice work!
a small related issue is that users added back/freshly added to the target remote share group do not have gain access to the share. Maybe we can throw in a user-added event here too?
Will add a behat test for the event listeners to ensure it works and doesn't break again. |
I noticed this as well, can you open an issue about it? I'm not sure how much work it will be and I don't think it's small enough to get it done in this PR. |
sounds good |
Signed-off-by: provokateurin <[email protected]>
…re providers Signed-off-by: provokateurin <[email protected]>
…eleted or users removed from a group Signed-off-by: provokateurin <[email protected]>
9714d53
to
f5b5aec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Fixes #35159
Fixes #50289
Summary
Checklist