chore(deps-dev): bump @zip.js/zip.js from 2.7.53 to 2.7.54

Bumps [@zip.js/zip.js](https://github.com/gildas-lormeau/zip.js) from 2.7.53 to 2.7.54. - [Release notes](https://github.com/gildas-lormeau/zip.js/releases) - [Commits](gildas-lormeau/zip.js@v2.7.53...v2.7.54) --- updated-dependencies: - dependency-name: "@zip.js/zip.js" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
nextcloud · dependabot · Jan 29, 2025 · Dec 21, 2024 · Jan 29, 2025 · 853cfa7070a0d7559d9260b96b7a9c9ee0c6d418
commit 853cfa7070a0d7559d9260b96b7a9c9ee0c6d418
@@ -142,7 +142,7 @@
     "@vitest/coverage-v8": "^2.1.8",
     "@vue/test-utils": "^1.3.5",
     "@vue/tsconfig": "^0.5.1",
-    "@zip.js/zip.js": "^2.7.53",
+    "@zip.js/zip.js": "^2.7.54",
     "babel-loader": "^9.2.1",
     "babel-loader-exclude-node-modules-except": "^1.2.1",
     "babel-plugin-module-resolver": "^5.0.2",

diff --git a/lib/private/App/InfoParser.php b/lib/private/App/InfoParser.php
 		}

 		libxml_use_internal_errors(true);
 		$xml = simplexml_load_string(file_get_contents($file));

 		if ($xml === false) {
 			libxml_clear_errors();
diff --git a/lib/private/AppFramework/Http/Dispatcher.php b/lib/private/AppFramework/Http/Dispatcher.php
 		}

 		$this->eventLogger->start('controller:' . get_class($controller) . '::' . $methodName, 'App framework controller execution');
 		$response = \call_user_func_array([$controller, $methodName], $arguments);
 		$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);

 		if (!($response instanceof Response)) {
diff --git a/lib/private/Installer.php b/lib/private/Installer.php

 	private static function includeAppScript(string $script): void {
 		if (file_exists($script)) {
 			include $script;
 		}
 	}
 }
diff --git a/lib/private/L10N/L10N.php b/lib/private/L10N/L10N.php
 	 * @return bool
 	 */
 	protected function load(string $translationFile): bool {
 		$json = json_decode(file_get_contents($translationFile), true);
 		if (!\is_array($json)) {
 			$jsonError = json_last_error();
 			\OCP\Server::get(LoggerInterface::class)->warning("Failed to load $translationFile - json error code: $jsonError", ['app' => 'l10n']);
diff --git a/lib/private/TaskProcessing/Manager.php b/lib/private/TaskProcessing/Manager.php
 				$task->setEndedAt(time());
 				$error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec';
 				$task->setErrorMessage($error);
 				$this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]);
 			} catch (NotPermittedException $e) {
 				$task->setProgress(1);
 				$task->setStatus(Task::STATUS_FAILED);
diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
 		\OC::$server->registerNamespace($app, $appNamespace);

 		if (file_exists($path . '/composer/autoload.php')) {
 			require_once $path . '/composer/autoload.php';
 		} else {
 			\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
 		}
diff --git a/apps/files/src/actions/convertUtils.ts b/apps/files/src/actions/convertUtils.ts
 *
 * @param view The current view
 * @param path The path to the file
 * @returns The parent folder
 */
 export const getParentFolder = function(view: View, path: string): Folder | null {
 	const filesStore = useFilesStore(getPinia())
diff --git a/apps/files/src/actions/moveOrCopyAction.ts b/apps/files/src/actions/moveOrCopyAction.ts
 * @param action The action to open the file picker for
 * @param dir The directory to start the file picker in
 * @param nodes The nodes to move/copy
 * @return The picked destination or false if cancelled by user
 */
 async function openFilePickerForAction(
 	action: MoveCopyAction,
diff --git a/apps/files/src/services/DropServiceUtils.spec.ts b/apps/files/src/services/DropServiceUtils.spec.ts
 }

 // This is mocking a file tree using the FileSystem API
 const buildFileSystemDirectoryEntry = (path: string, tree: any): FileSystemDirectoryEntry => {
 	const entries = Object.entries(tree).map(([name, contents]) => {
 		const fullPath = join(path, name)
 		if (Array.isArray(contents)) {
 	return new FileSystemDirectoryEntry(path, entries)
 }

 const buildDataTransferItemArray = (path: string, tree: any, isFileSystemAPIAvailable = true): DataTransferItemMock[] => {
 	return Object.entries(tree).map(([name, contents]) => {
 		const fullPath = join(path, name)
 		if (Array.isArray(contents)) {
diff --git a/apps/files/src/store/files.ts b/apps/files/src/store/files.ts
 		getters: {
 			/**
 			 * Get a file or folder by its source
 			 * @param state
 			 */
 			getNode: (state) => (source: FileSource): Node|undefined => state.files[source],

 			/**
 			 * Get a list of files or folders by their IDs
 			 * Note: does not return undefined values
 			 * @param state
 			 */
 			getNodes: (state) => (sources: FileSource[]): Node[] => sources
 				.map(source => state.files[source])
 			 * Get files or folders by their file ID
 			 * Multiple nodes can have the same file ID but different sources
 			 * (e.g. in a shared context)
 			 * @param state
 			 */
 			getNodesById: (state) => (fileId: number): Node[] => Object.values(state.files).filter(node => node.fileid === fileId),

 			/**
 			 * Get the root folder of a service
 			 * @param state
 			 */
 			getRoot: (state) => (service: Service): Folder|undefined => state.roots[service],
 		},
 			 *
 			 * @param service The service (files view)
 			 * @param path The path relative within the service
 			 * @return Array of cached nodes within the path
 			 */
 			getNodesByPath(service: string, path?: string): Node[] {
 				const pathsStore = usePathsStore()
diff --git a/apps/files/src/store/filters.ts b/apps/files/src/store/filters.ts
 	 * All filters that provide a UI for visual controlling the filter state
 	 */
 	const filtersWithUI = computed<Required<IFileListFilter>[]>(
 		() => sortedFilters.value.filter(isFileListFilterWithUi)
 	)

 	/**
	}

	libxml_use_internal_errors(true);
	$xml = simplexml_load_string(file_get_contents($file));
Check failure on line 38 in lib/private/App/InfoParser.php GitHub Actions / static-code-analysis-security TaintedFile `lib/private/App/InfoParser.php:38:50: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)`

	if ($xml === false) {
	libxml_clear_errors();
	}

	$this->eventLogger->start('controller:' . get_class($controller) . '::' . $methodName, 'App framework controller execution');
	$response = \call_user_func_array([$controller, $methodName], $arguments);
Check failure on line 200 in lib/private/AppFramework/Http/Dispatcher.php GitHub Actions / static-code-analysis-security TaintedCallable `lib/private/AppFramework/Http/Dispatcher.php:200:37: TaintedCallable: Detected tainted text (see https://psalm.dev/243)`
	$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);

	if (!($response instanceof Response)) {

	private static function includeAppScript(string $script): void {
	if (file_exists($script)) {
	include $script;
Check failure on line 587 in lib/private/Installer.php GitHub Actions / static-code-analysis-security TaintedInclude `lib/private/Installer.php:587:12: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)`
	}
	}
	}
	* @return bool
	*/
	protected function load(string $translationFile): bool {
	$json = json_decode(file_get_contents($translationFile), true);
Check failure on line 215 in lib/private/L10N/L10N.php GitHub Actions / static-code-analysis-security TaintedFile `lib/private/L10N/L10N.php:215:41: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)`
	if (!\is_array($json)) {
	$jsonError = json_last_error();
	\OCP\Server::get(LoggerInterface::class)->warning("Failed to load $translationFile - json error code: $jsonError", ['app' => 'l10n']);
	$task->setEndedAt(time());
	$error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec';
	$task->setErrorMessage($error);
	$this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]);
Check failure on line 1002 in lib/private/TaskProcessing/Manager.php GitHub Actions / static-code-analysis-security TaintedHtml `lib/private/TaskProcessing/Manager.php:1002:64: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)`
	} catch (NotPermittedException $e) {
	$task->setProgress(1);
	$task->setStatus(Task::STATUS_FAILED);
	\OC::$server->registerNamespace($app, $appNamespace);

	if (file_exists($path . '/composer/autoload.php')) {
	require_once $path . '/composer/autoload.php';
Check failure on line 115 in lib/private/legacy/OC_App.php GitHub Actions / static-code-analysis-security TaintedInclude `lib/private/legacy/OC_App.php:115:17: TaintedInclude: Detected tainted code passed to include or similar (see https://psalm.dev/251)`
	} else {
	\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
	}
	*
	* @param view The current view
	* @param path The path to the file
	* @returns The parent folder
Check warning on line 134 in apps/files/src/actions/convertUtils.ts GitHub Actions / NPM lint `Invalid JSDoc tag (preference). Replace "returns" JSDoc tag with "return"`
	*/
	export const getParentFolder = function(view: View, path: string): Folder \| null {
	const filesStore = useFilesStore(getPinia())
	* @param action The action to open the file picker for
	* @param dir The directory to start the file picker in
	* @param nodes The nodes to move/copy
	* @return The picked destination or false if cancelled by user
Check warning on line 210 in apps/files/src/actions/moveOrCopyAction.ts GitHub Actions / NPM lint `Missing JSDoc @return type`
	*/
	async function openFilePickerForAction(
	action: MoveCopyAction,
	}

	// This is mocking a file tree using the FileSystem API
	const buildFileSystemDirectoryEntry = (path: string, tree: any): FileSystemDirectoryEntry => {
Check warning on line 25 in apps/files/src/services/DropServiceUtils.spec.ts GitHub Actions / NPM lint `Unexpected any. Specify a different type`
	const entries = Object.entries(tree).map(([name, contents]) => {
	const fullPath = join(path, name)
	if (Array.isArray(contents)) {
	return new FileSystemDirectoryEntry(path, entries)
	}

	const buildDataTransferItemArray = (path: string, tree: any, isFileSystemAPIAvailable = true): DataTransferItemMock[] => {
Check warning on line 37 in apps/files/src/services/DropServiceUtils.spec.ts GitHub Actions / NPM lint `Unexpected any. Specify a different type`
	return Object.entries(tree).map(([name, contents]) => {
	const fullPath = join(path, name)
	if (Array.isArray(contents)) {
	getters: {
	/**
	* Get a file or folder by its source
	* @param state
Check warning on line 27 in apps/files/src/store/files.ts GitHub Actions / NPM lint `Missing JSDoc @param "state" description`
	*/
	getNode: (state) => (source: FileSource): Node\|undefined => state.files[source],

	/**
	* Get a list of files or folders by their IDs
	* Note: does not return undefined values
	* @param state
Check warning on line 34 in apps/files/src/store/files.ts GitHub Actions / NPM lint `Missing JSDoc @param "state" description`
	*/
	getNodes: (state) => (sources: FileSource[]): Node[] => sources
	.map(source => state.files[source])
	* Get files or folders by their file ID
	* Multiple nodes can have the same file ID but different sources
	* (e.g. in a shared context)
	* @param state
Check warning on line 44 in apps/files/src/store/files.ts GitHub Actions / NPM lint `Missing JSDoc @param "state" description`
	*/
	getNodesById: (state) => (fileId: number): Node[] => Object.values(state.files).filter(node => node.fileid === fileId),

	/**
	* Get the root folder of a service
	* @param state
Check warning on line 50 in apps/files/src/store/files.ts GitHub Actions / NPM lint `Missing JSDoc @param "state" description`
	*/
	getRoot: (state) => (service: Service): Folder\|undefined => state.roots[service],
	},
	*
	* @param service The service (files view)
	* @param path The path relative within the service
	* @return Array of cached nodes within the path
Check warning on line 61 in apps/files/src/store/files.ts GitHub Actions / NPM lint `Missing JSDoc @return type`
	*/
	getNodesByPath(service: string, path?: string): Node[] {
	const pathsStore = usePathsStore()