Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fail psalm when baseline update required #48466

Merged
merged 1 commit into from
Sep 30, 2024
Merged

ci: fail psalm when baseline update required #48466

merged 1 commit into from
Sep 30, 2024
+2 −2

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 30, 2024 •
edited
Loading

Summary

Psalm now fails when a baseline update is needed.

TODO

  • CI
  • No warning about invalid sarif file

Checklist

@kesselb kesselb self-assigned this Sep 30, 2024
@kesselb kesselb added the 2. developing Work in progress label Sep 30, 2024
@kesselb kesselb force-pushed the ci/noid/require-up-to-date-psalm-paseline branch from e9c0c2f to 077ed74 Compare September 30, 2024 16:05
@kesselb kesselb changed the title ci: dont update psalm baseline ci: fail psalm when baseline update required Sep 30, 2024
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 30, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Sep 30, 2024
provokateurin
provokateurin approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but better than nothing 👍

@kesselb kesselb merged commit 1fff4e1 into master Sep 30, 2024
174 checks passed
@kesselb kesselb deleted the ci/noid/require-up-to-date-psalm-paseline branch September 30, 2024 17:00
@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable30

@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable29

@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable28

@backportbot backportbot bot mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @miaulalala @provokateurin